Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: update package list with mapbox-gl #17955

Closed
wants to merge 1 commit into from
Closed

Conversation

hughhhh
Copy link
Member

@hughhhh hughhhh commented Jan 6, 2022

SUMMARY

When install superset-frontend we starting clean repo. This PR represents the changes need and running npm install in these directories:

superset/superset-frontend/plugins/legacy-plugin-chart-map-box
superset/superset-frontend/plugins/legacy-preset-chart-deckgl

Error:

ERROR in ./plugins/legacy-plugin-chart-map-box/src/ScatterPlotGlowOverlay.jsx 26:0-38
Module not found: Error: Can't resolve 'mapbox-gl/dist/mapbox-gl.css' in '/Users/hugh/src/superset/superset-frontend/plugins/legacy-plugin-chart-map-box/src'

ERROR in ./plugins/legacy-preset-chart-deckgl/src/DeckGLContainer.jsx 29:0-38
Module not found: Error: Can't resolve 'mapbox-gl/dist/mapbox-gl.css' in '/Users/hugh/src/superset/superset-frontend/plugins/legacy-preset-chart-deckgl/src'

BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF

TESTING INSTRUCTIONS

ADDITIONAL INFORMATION

  • Has associated issue:
  • Required feature flags:
  • Changes UI
  • Includes DB Migration (follow approval process in SIP-59)
    • Migration is atomic, supports rollback & is backwards-compatible
    • Confirm DB migration upgrade and downgrade tested
    • Runtime estimates and downtime expectations provided
  • Introduces new feature or API
  • Removes existing feature or API

@codecov
Copy link

codecov bot commented Jan 6, 2022

Codecov Report

Merging #17955 (a328ce0) into master (f75908b) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master   #17955   +/-   ##
=======================================
  Coverage   67.07%   67.07%           
=======================================
  Files        1609     1609           
  Lines       64905    64905           
  Branches     6868     6868           
=======================================
  Hits        43537    43537           
  Misses      19502    19502           
  Partials     1866     1866           
Flag Coverage Δ
hive 53.29% <ø> (ø)
mysql 82.19% <ø> (ø)
postgres 82.24% <ø> (ø)
presto 53.13% <ø> (ø)
python 82.68% <ø> (ø)
sqlite 81.92% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.


Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f75908b...a328ce0. Read the comment docs.

@etr2460
Copy link
Member

etr2460 commented Jan 8, 2022

I thought that @zhaoyongjie just removed this to fix another issue? FWIW, I was wrestling with the above error before, and realized it was because i was npm installing with the --legacy-peer-deps option, and replacing that with --force fixed it for me. I don't know what the correct solution is, but sharing what i hit today for extra context

@zhaoyongjie
Copy link
Member

@hughhhh @etr2460 the related PR at here. I think that mapbox-gl installed as a dependence from react-map-gl.

@hughhhh hughhhh closed this Jan 10, 2022
@hughhhh
Copy link
Member Author

hughhhh commented Jan 14, 2022

just npm install mapbox-gl fixed this issue for me

@eschutho
Copy link
Member

@hughhhh can we see if we can find a longer-term fix? Any reason why we can't merge your pr? Or maybe we need to have someone run npm install with --force and push up that pr with the updated package-lock.json file.

@mistercrunch mistercrunch deleted the monorepo-install-fix branch March 26, 2024 16:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants