-
Notifications
You must be signed in to change notification settings - Fork 13.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: dashboard full screen layout #17985
Conversation
Codecov Report
@@ Coverage Diff @@
## master #17985 +/- ##
=======================================
Coverage 67.10% 67.10%
=======================================
Files 1612 1612
Lines 64999 65000 +1
Branches 6872 6873 +1
=======================================
+ Hits 43616 43619 +3
+ Misses 19513 19512 -1
+ Partials 1870 1869 -1
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
/testenv up |
@pkdotson Ephemeral environment spinning up at http://52.13.228.119:8080. Credentials are |
Ephemeral environment shutdown and build artifacts deleted. |
🏷 2022.1 |
* fix: full screen mode for dashboard * remove console (cherry picked from commit c139312)
* fix: full screen mode for dashboard * remove console
* fix: full screen mode for dashboard * remove console
SUMMARY
This pr possibly fixes an issue where user enter full screen and the page errors out. This could be possibly because of an outdated param passed into the getdashboardurl util.
BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF
Screen.Recording.2022-01-10.at.1.41.54.PM.mov
TESTING INSTRUCTIONS
Go to dashboard and go to three dots and click enter full screen mode. Should enter and exit without error.
ADDITIONAL INFORMATION