Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(histogram): display correct percentile value instead of formula #18084

Merged
merged 2 commits into from
Feb 9, 2022

Conversation

hoangminhquan-lhsdt
Copy link
Contributor

@hoangminhquan-lhsdt hoangminhquan-lhsdt commented Jan 19, 2022

SUMMARY

This PR addresses issue #17550 regarding histogram percentile displaying the formula instead of the value. The long formula also causes the entire tooltip box to be long, which possibly leads to the entire tooltip being hidden to the side of the plot.

BEFORE

Screenshot from 2022-01-19 09-26-36

AFTER

Screenshot from 2022-01-19 09-34-39

TESTING INSTRUCTIONS

  • Open any histogram chart, "FCC 2018 Survey's Age distribution of respondents" is an included example.
  • Hover the mouse pointer over any column to see the percentile value in the tooltip.

ADDITIONAL INFORMATION

  • Has associated issue: Fixes [histogram] percentile value in tooltip shows formula instead of value #17550
  • Required feature flags: Disables prettier linting in superset-frontend/plugins/legacy-plugin-chart-histogram/src/Histogram.jsx to prevent ERROR related to line length during npm build.
  • Changes UI: no
  • Includes DB Migration (follow approval process in SIP-59): no
    • Migration is atomic, supports rollback & is backwards-compatible: N/A
    • Confirm DB migration upgrade and downgrade tested: N/A
    • Runtime estimates and downtime expectations provided: N/A
  • Introduces new feature or API: no
  • Removes existing feature or API: no

@@ -26,3 +26,4 @@ CHANGELOG.md
*-topo.json
temporary_superset_ui/
storybook-static/
plugins/legacy-plugins-chart-histogram/src/Histogram.jsx
Copy link
Member

@nytai nytai Feb 9, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

why is this necessary? Can you just run prettier or fix the error instead of ignoring this file?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

When I first ran Prettier on the file, it didn't change anything. I suspect it was because either I misconfigured Prettier on my local machine, or Prettier confused and couldn't reformat. I will try to configure it again.

@codecov
Copy link

codecov bot commented Feb 9, 2022

Codecov Report

Merging #18084 (da92ee8) into master (8dea7f5) will decrease coverage by 0.04%.
The diff coverage is n/a.

❗ Current head da92ee8 differs from pull request most recent head ab067bd. Consider uploading reports for the commit ab067bd to get more accurate results

Impacted file tree graph

@@            Coverage Diff             @@
##           master   #18084      +/-   ##
==========================================
- Coverage   66.36%   66.31%   -0.05%     
==========================================
  Files        1570     1595      +25     
  Lines       61740    62596     +856     
  Branches     6241     6297      +56     
==========================================
+ Hits        40972    41510     +538     
- Misses      19170    19440     +270     
- Partials     1598     1646      +48     
Flag Coverage Δ
javascript 51.33% <ø> (+0.41%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
superset/examples/multi_line.py 0.00% <0.00%> (-53.85%) ⬇️
superset/commands/importers/v1/examples.py 0.00% <0.00%> (-39.33%) ⬇️
superset/examples/big_data.py 0.00% <0.00%> (-35.00%) ⬇️
superset/examples/misc_dashboard.py 0.00% <0.00%> (-33.34%) ⬇️
superset/examples/utils.py 0.00% <0.00%> (-28.58%) ⬇️
superset/examples/tabbed_dashboard.py 0.00% <0.00%> (-27.59%) ⬇️
superset/db_engine_specs/teradata.py 62.75% <0.00%> (-27.25%) ⬇️
superset/examples/bart_lines.py 0.00% <0.00%> (-25.81%) ⬇️
superset/utils/mock_data.py 0.00% <0.00%> (-25.19%) ⬇️
superset/examples/paris.py 0.00% <0.00%> (-25.00%) ⬇️
... and 213 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8dea7f5...ab067bd. Read the comment docs.

@nytai nytai merged commit 28e729b into apache:master Feb 9, 2022
@mistercrunch mistercrunch added 🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels 🚢 1.5.0 labels Mar 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels size/XS 🚢 1.5.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[histogram] percentile value in tooltip shows formula instead of value
3 participants