Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: Docusaurus throw on broken links #18230

Merged
merged 1 commit into from
Jan 31, 2022
Merged

chore: Docusaurus throw on broken links #18230

merged 1 commit into from
Jan 31, 2022

Conversation

geido
Copy link
Member

@geido geido commented Jan 31, 2022

SUMMARY

This PR brings back the configuration of broken links to throw errors when found. This should guarantee that the docs will always have working links.

This PR also fixes some additional broken links found during the build, that should now succeed without any error.

TESTING INSTRUCTIONS

  1. Build the docs with npm run build
  2. Make sure the build is successful

ADDITIONAL INFORMATION

  • Has associated issue:
  • Required feature flags:
  • Changes UI
  • Includes DB Migration (follow approval process in SIP-59)
    • Migration is atomic, supports rollback & is backwards-compatible
    • Confirm DB migration upgrade and downgrade tested
    • Runtime estimates and downtime expectations provided
  • Introduces new feature or API
  • Removes existing feature or API

@geido geido requested review from villebro, hughhhh and srinify and removed request for villebro January 31, 2022 14:32
@geido geido removed the Flexiana label Jan 31, 2022
@geido geido requested a review from villebro January 31, 2022 14:34
@srinify srinify merged commit e12b5bc into apache:master Jan 31, 2022
shcoderAlex pushed a commit to casual-precision/superset that referenced this pull request Feb 7, 2022
@geido @shcoderAlex
Fix broken links (apache#18230)
66d63ef
ofekisr pushed a commit to nielsen-oss/superset that referenced this pull request Feb 8, 2022
@geido @ofekisr
Fix broken links (apache#18230)
9eb5e7c
bwang221 pushed a commit to casual-precision/superset that referenced this pull request Feb 10, 2022
@geido @bwang221
Fix broken links (apache#18230)
677bb79
@mistercrunch mistercrunch added 🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels 🚢 1.5.0 labels Mar 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@srinify srinify srinify approved these changes

@hughhhh hughhhh Awaiting requested review from hughhhh

@villebro villebro Awaiting requested review from villebro

Assignees
No one assigned
Labels
🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels size/S 🚢 1.5.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@geido @srinify @mistercrunch