Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Rename and reposition native filter modal fields #18558

Conversation

michael-s-molina
Copy link
Member

SUMMARY

The objective of this PR is to improve the naming and organization of the native filters modal. The changes are the result of a series of interviews conducted by the design team with Superset users. This is just a subset of the proposed changes, we'll have more in follow-up PRs.

Another small change is that both sections in the Settings tab are expanded by default.

@jinghua-qa @kasiazjc Nesting and limiting will be handled by follow-up PRs.

BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF

Screen.Recording.2022-02-02.at.2.43.36.PM.mov
Screen.Recording.2022-02-02.at.2.40.56.PM.mov

TESTING INSTRUCTIONS

All the features should continue to work as before.

ADDITIONAL INFORMATION

  • Has associated issue:
  • Required feature flags:
  • Changes UI
  • Includes DB Migration (follow approval process in SIP-59)
    • Migration is atomic, supports rollback & is backwards-compatible
    • Confirm DB migration upgrade and downgrade tested
    • Runtime estimates and downtime expectations provided
  • Introduces new feature or API
  • Removes existing feature or API

@codecov
Copy link

codecov bot commented Feb 2, 2022

Codecov Report

Merging #18558 (f2409c3) into master (8c37654) will decrease coverage by 0.03%.
The diff coverage is 39.21%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master   #18558      +/-   ##
==========================================
- Coverage   66.32%   66.29%   -0.04%     
==========================================
  Files        1592     1595       +3     
  Lines       62569    62582      +13     
  Branches     6295     6298       +3     
==========================================
- Hits        41500    41489      -11     
- Misses      19416    19447      +31     
+ Partials     1653     1646       -7     
Flag Coverage Δ
javascript 51.32% <39.21%> (-0.06%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...tiveFilters/FiltersConfigModal/FilterTitlePane.tsx 81.25% <ø> (-3.75%) ⬇️
...ters/FiltersConfigModal/FiltersConfigForm/state.ts 65.62% <0.00%> (ø)
...end/src/filters/components/GroupBy/controlPanel.ts 100.00% <ø> (ø)
...ntend/src/filters/components/Range/controlPanel.ts 100.00% <ø> (ø)
...tend/src/filters/components/Select/controlPanel.ts 100.00% <ø> (ø)
...et-frontend/src/filters/components/Select/types.ts 100.00% <ø> (ø)
...ontend/src/filters/components/Time/controlPanel.ts 100.00% <ø> (ø)
.../src/filters/components/TimeColumn/controlPanel.ts 100.00% <ø> (ø)
...d/src/filters/components/TimeGrain/controlPanel.ts 100.00% <ø> (ø)
...onfigModal/FiltersConfigForm/FiltersConfigForm.tsx 59.01% <37.77%> (-0.86%) ⬇️
... and 32 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8c37654...f2409c3. Read the comment docs.

@rusackas
Copy link
Member

rusackas commented Feb 7, 2022

/testenv up

@github-actions
Copy link
Contributor

github-actions bot commented Feb 7, 2022

@rusackas Ephemeral environment spinning up at http://34.218.60.199:8080. Credentials are admin/admin. Please allow several minutes for bootstrapping and startup.

Copy link
Member

@geido geido left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM with a minor comment

Copy link
Member

@rusackas rusackas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@michael-s-molina michael-s-molina merged commit fdf57cc into apache:master Feb 8, 2022
@github-actions
Copy link
Contributor

github-actions bot commented Feb 8, 2022

Ephemeral environment shutdown and build artifacts deleted.

@mistercrunch mistercrunch added 🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels 🚢 1.5.0 labels Mar 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels size/XL 🚢 1.5.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants