-
Notifications
You must be signed in to change notification settings - Fork 13.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(explore): Implement chart empty states #18678
Conversation
5d7b1fd
to
e16438f
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great to me!
e16438f
to
c60749f
Compare
Codecov Report
@@ Coverage Diff @@
## master #18678 +/- ##
==========================================
+ Coverage 66.32% 66.35% +0.03%
==========================================
Files 1619 1619
Lines 62939 62943 +4
Branches 6341 6345 +4
==========================================
+ Hits 41742 41767 +25
+ Misses 19545 19521 -24
- Partials 1652 1655 +3
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
SUMMARY
This PR implements chart empty states for 2 scenarios:
BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF
TESTING INSTRUCTIONS
ADDITIONAL INFORMATION
CC @kasiazjc
https://app.shortcut.com/preset/story/36403/explore-empty-states