-
Notifications
You must be signed in to change notification settings - Fork 13.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(allow-db-explore): make that the set the allow-db-explore option #19030
Conversation
Codecov Report
@@ Coverage Diff @@
## master #19030 +/- ##
=======================================
Coverage 66.52% 66.52%
=======================================
Files 1641 1641
Lines 63475 63475
Branches 6443 6443
=======================================
Hits 42226 42226
Misses 19584 19584
Partials 1665 1665
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
Looks good and makes sense to me, but is it ok if I loop in a PM? :) cc: @yousoph |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Approving for code, adding hold
label for review :)
/testenv up |
@rusackas Ephemeral environment spinning up at http://52.37.99.2:8080. Credentials are |
@yousoph took a look. All good!!! |
Ephemeral environment shutdown and build artifacts deleted. |
SUMMARY
The "Allow this database to be explored" setting should be checked by default in the Database Connection UI
How to reproduce the bug
BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF
BEFORE:
AFTER:
ADDITIONAL INFORMATION