-
Notifications
You must be signed in to change notification settings - Fork 13.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(dashboard-edge-cutting): make to be not cut without Filter #19080
fix(dashboard-edge-cutting): make to be not cut without Filter #19080
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good
Codecov Report
@@ Coverage Diff @@
## master #19080 +/- ##
=======================================
Coverage 66.51% 66.51%
=======================================
Files 1643 1643
Lines 63462 63462
Branches 6449 6449
=======================================
Hits 42210 42210
Misses 19582 19582
Partials 1670 1670
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
/testenv up |
@rusackas Ephemeral environment spinning up at http://54.202.249.160:8080. Credentials are |
/testenv up FEATURE_DASHBOARD_NATIVE_FILTERS=false |
@rusackas Ephemeral environment spinning up at http://35.86.252.55:8080. Credentials are |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The part that bothers me about this issue (not the PR) is that we've fixed this sort of issue multiple times. We need visual regression testing on this project to catch this sort of thing when it (re)occurs.
Nonetheless, LGTM, thanks for the fix.
Ephemeral environment shutdown and build artifacts deleted. |
(cherry picked from commit 158396f)
SUMMARY
[dashboard][cosmetic] When dashboard has no native filter, the left edge is cut.
BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF
BEFORE:
AFTER:
TESTING INSTRUCTIONS
ADDITIONAL INFORMATION