Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(dashboard-edge-cutting): make to be not cut without Filter #19080

Merged

Conversation

prosdev0107
Copy link
Contributor

@prosdev0107 prosdev0107 commented Mar 9, 2022

SUMMARY

[dashboard][cosmetic] When dashboard has no native filter, the left edge is cut.

BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF

BEFORE:
image

AFTER:
image

TESTING INSTRUCTIONS

  1. Go to the dashboard as a limited contributor.
  2. Click on a owned dashboard.
  3. Go back to the dashboard list.
  4. Click on a not owned dashboard (did not setup native filter) that with data access.
  5. Observe the dashboard.

ADDITIONAL INFORMATION

  • Has associated issue:
  • Required feature flags:
  • Changes UI
  • Includes DB Migration (follow approval process in SIP-59)
    • Migration is atomic, supports rollback & is backwards-compatible
    • Confirm DB migration upgrade and downgrade tested
    • Runtime estimates and downtime expectations provided
  • Introduces new feature or API
  • Removes existing feature or API

Copy link
Contributor

@codemaster08240328 codemaster08240328 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good

@codecov
Copy link

codecov bot commented Mar 9, 2022

Codecov Report

Merging #19080 (c386c2b) into master (79a7a5d) will not change coverage.
The diff coverage is 0.00%.

❗ Current head c386c2b differs from pull request most recent head d91df8a. Consider uploading reports for the commit d91df8a to get more accurate results

Impacted file tree graph

@@           Coverage Diff           @@
##           master   #19080   +/-   ##
=======================================
  Coverage   66.51%   66.51%           
=======================================
  Files        1643     1643           
  Lines       63462    63462           
  Branches     6449     6449           
=======================================
  Hits        42210    42210           
  Misses      19582    19582           
  Partials     1670     1670           
Flag Coverage Δ
javascript 51.24% <0.00%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...d/components/DashboardBuilder/DashboardBuilder.tsx 72.72% <0.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 79a7a5d...d91df8a. Read the comment docs.

@rusackas
Copy link
Member

/testenv up

@github-actions
Copy link
Contributor

@rusackas Ephemeral environment spinning up at http://54.202.249.160:8080. Credentials are admin/admin. Please allow several minutes for bootstrapping and startup.

@rusackas
Copy link
Member

/testenv up FEATURE_DASHBOARD_NATIVE_FILTERS=false

@github-actions
Copy link
Contributor

@rusackas Ephemeral environment spinning up at http://35.86.252.55:8080. Credentials are admin/admin. Please allow several minutes for bootstrapping and startup.

Copy link
Member

@rusackas rusackas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The part that bothers me about this issue (not the PR) is that we've fixed this sort of issue multiple times. We need visual regression testing on this project to catch this sort of thing when it (re)occurs.

Nonetheless, LGTM, thanks for the fix.

@rusackas rusackas merged commit 158396f into apache:master Mar 10, 2022
@github-actions
Copy link
Contributor

Ephemeral environment shutdown and build artifacts deleted.

villebro pushed a commit that referenced this pull request Apr 3, 2022
@mistercrunch mistercrunch added 🍒 1.5.0 🍒 1.5.1 🍒 1.5.2 🍒 1.5.3 🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels 🚢 2.0.0 labels Mar 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels lts-v1 size/S 🍒 1.5.0 🍒 1.5.1 🍒 1.5.2 🍒 1.5.3 🚢 2.0.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants