Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: allow overriding the guest token pyjwt instance #19293

Merged
merged 1 commit into from
Mar 21, 2022

Conversation

suddjian
Copy link
Member

SUMMARY

At Preset, we use one set of config for the global JWT instance and want to use a different config for our guest token JWTs.

TESTING INSTRUCTIONS

Covered by unit tests.

ADDITIONAL INFORMATION

  • Has associated issue:
  • Required feature flags:
  • Changes UI
  • Includes DB Migration (follow approval process in SIP-59)
    • Migration is atomic, supports rollback & is backwards-compatible
    • Confirm DB migration upgrade and downgrade tested
    • Runtime estimates and downtime expectations provided
  • Introduces new feature or API
  • Removes existing feature or API

Copy link
Member

@lilykuang lilykuang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@codecov
Copy link

codecov bot commented Mar 21, 2022

Codecov Report

Merging #19293 (0e60959) into master (d771ddb) will increase coverage by 0.05%.
The diff coverage is 100.00%.

❗ Current head 0e60959 differs from pull request most recent head 8727271. Consider uploading reports for the commit 8727271 to get more accurate results

@@            Coverage Diff             @@
##           master   #19293      +/-   ##
==========================================
+ Coverage   66.59%   66.64%   +0.05%     
==========================================
  Files        1670     1670              
  Lines       64587    64588       +1     
  Branches     6505     6505              
==========================================
+ Hits        43009    43045      +36     
+ Misses      19895    19860      -35     
  Partials     1683     1683              
Flag Coverage Δ
hive 52.60% <50.00%> (+<0.01%) ⬆️
mysql 81.62% <100.00%> (+<0.01%) ⬆️
postgres 81.67% <100.00%> (+<0.01%) ⬆️
presto 52.45% <50.00%> (?)
python 82.09% <100.00%> (+0.10%) ⬆️
sqlite 81.44% <100.00%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
superset/security/manager.py 95.11% <100.00%> (+<0.01%) ⬆️
superset/models/core.py 89.04% <0.00%> (+0.23%) ⬆️
superset/connectors/sqla/models.py 89.64% <0.00%> (+1.02%) ⬆️
superset/db_engine_specs/presto.py 89.12% <0.00%> (+4.81%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d771ddb...8727271. Read the comment docs.

@suddjian suddjian merged commit f9feb1b into apache:master Mar 21, 2022
michael-hoffman-26 pushed a commit to nielsen-oss/superset that referenced this pull request Mar 23, 2022
sadpandajoe pushed a commit to preset-io/superset that referenced this pull request Mar 31, 2022
villebro pushed a commit that referenced this pull request Apr 3, 2022
@sadpandajoe
Copy link
Member

🏷️ preset:2022.11

@mistercrunch mistercrunch added 🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels 🚢 2.0.0 and removed 🚢 2.0.1 labels Mar 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels lts-v1 preset:2022.11 preset-io size/XS 🍒 1.5.0 🍒 1.5.1 🍒 1.5.2 🍒 1.5.3 🚢 2.0.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants