Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: external management flags in CRUD #19318

Merged

Conversation

betodealmeida
Copy link
Member

SUMMARY

Add is_managed_externally and external_url to the POST/PUT schemas for all resources that have the columns (databases, datasets, charts, dashboards). This allows us to create resources that are flagged as manged externally, as well as update existing ones.

BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF

N/A

TESTING INSTRUCTIONS

WIP, adding unit tests.

ADDITIONAL INFORMATION

  • Has associated issue:
  • Required feature flags:
  • Changes UI
  • Includes DB Migration (follow approval process in SIP-59)
    • Migration is atomic, supports rollback & is backwards-compatible
    • Confirm DB migration upgrade and downgrade tested
    • Runtime estimates and downtime expectations provided
  • Introduces new feature or API
  • Removes existing feature or API

@codecov
Copy link

codecov bot commented Mar 23, 2022

Codecov Report

Merging #19318 (f0fd7ed) into master (7ca10fb) will increase coverage by 0.00%.
The diff coverage is 100.00%.

@@           Coverage Diff           @@
##           master   #19318   +/-   ##
=======================================
  Coverage   66.65%   66.66%           
=======================================
  Files        1672     1672           
  Lines       64611    64627   +16     
  Branches     6505     6505           
=======================================
+ Hits        43066    43082   +16     
  Misses      19862    19862           
  Partials     1683     1683           
Flag Coverage Δ
hive 52.67% <100.00%> (+0.02%) ⬆️
mysql 81.66% <100.00%> (+<0.01%) ⬆️
postgres 81.71% <100.00%> (+<0.01%) ⬆️
presto 52.52% <100.00%> (+0.02%) ⬆️
python 82.13% <100.00%> (+<0.01%) ⬆️
sqlite 81.48% <100.00%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
superset/charts/schemas.py 99.34% <100.00%> (+<0.01%) ⬆️
superset/dashboards/schemas.py 99.43% <100.00%> (+0.01%) ⬆️
superset/databases/schemas.py 98.50% <100.00%> (+0.02%) ⬆️
superset/datasets/schemas.py 97.26% <100.00%> (+0.07%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7ca10fb...f0fd7ed. Read the comment docs.

@betodealmeida betodealmeida merged commit 9766726 into apache:master Mar 23, 2022
villebro pushed a commit that referenced this pull request Apr 3, 2022
philipher29 pushed a commit to ValtechMobility/superset that referenced this pull request Jun 9, 2022
@mistercrunch mistercrunch added 🍒 1.5.0 🍒 1.5.1 🍒 1.5.2 🍒 1.5.3 🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels 🚢 2.0.0 labels Mar 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels lts-v1 size/S 🍒 1.5.0 🍒 1.5.1 🍒 1.5.2 🍒 1.5.3 🚢 2.0.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants