-
Notifications
You must be signed in to change notification settings - Fork 13.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: Removes direct theme imports #19368
chore: Removes direct theme imports #19368
Conversation
<ToastContainer /> | ||
</div> | ||
</ThemeProvider> | ||
<div className="App SqlLab"> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ThemeProvider
is already being set in src/SqlLab/App.jsx
Codecov Report
@@ Coverage Diff @@
## master #19368 +/- ##
==========================================
+ Coverage 66.48% 66.67% +0.19%
==========================================
Files 1670 1676 +6
Lines 63958 64717 +759
Branches 6506 6506
==========================================
+ Hits 42525 43153 +628
- Misses 19747 19878 +131
Partials 1686 1686
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
e3959b4
to
ff9ec19
Compare
SUMMARY
Removes remaining direct theme imports to make the components themeable. Test files are not affected.
This PR also disables the
no-restricted-imports
lint rule in test files since legacy tests are importing the theme directly.TESTING INSTRUCTIONS
1 - Execute all tests
2 - All tests should pass
ADDITIONAL INFORMATION