-
Notifications
You must be signed in to change notification settings - Fork 13.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: native filter dropdown not attached to parent node #19399
fix: native filter dropdown not attached to parent node #19399
Conversation
Codecov Report
@@ Coverage Diff @@
## master #19399 +/- ##
==========================================
- Coverage 66.59% 66.43% -0.17%
==========================================
Files 1682 1670 -12
Lines 64314 63960 -354
Branches 6559 6507 -52
==========================================
- Hits 42832 42491 -341
- Misses 19781 19783 +2
+ Partials 1701 1686 -15
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
/testenv up |
@rusackas Ephemeral environment spinning up at http://54.184.17.120:8080. Credentials are |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! Works great in testing!
defccb6
to
e614d80
Compare
Ephemeral environment shutdown and build artifacts deleted. |
(cherry picked from commit c5b0dc3)
🏷️ preset:2022.13 |
SUMMARY
This PR addresses the issue mentioned in #18102
By attaching the select popover to the parent node, we ensure it's tied to the left side content and thus scroll with it.
We can also leverage the Select's own calculations for top/bottom placement.
BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF
Before:
Screen.Recording.2022-03-28.at.14.35.47.mov
After:
Screen.Recording.2022-03-28.at.14.27.25.mov
TESTING INSTRUCTIONS
ADDITIONAL INFORMATION