Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(plugin-chart-echarts): upgrade echarts 5.3.2 #19481

Merged
merged 1 commit into from
Apr 1, 2022

Conversation

villebro
Copy link
Member

@villebro villebro commented Apr 1, 2022

SUMMARY

Upgrade ECharts to the latest 5.3.2 version. See changelog here (mostly unrelated to current Superset features): https://echarts.apache.org/en/changelog.html#v5-3-2

TESTING INSTRUCTIONS

Local testing

ADDITIONAL INFORMATION

  • Has associated issue:
  • Required feature flags:
  • Changes UI
  • Includes DB Migration (follow approval process in SIP-59)
    • Migration is atomic, supports rollback & is backwards-compatible
    • Confirm DB migration upgrade and downgrade tested
    • Runtime estimates and downtime expectations provided
  • Introduces new feature or API
  • Removes existing feature or API

@codecov
Copy link

codecov bot commented Apr 1, 2022

Codecov Report

Merging #19481 (3add8eb) into master (eab9388) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master   #19481   +/-   ##
=======================================
  Coverage   66.58%   66.58%           
=======================================
  Files        1676     1676           
  Lines       64176    64176           
  Branches     6525     6525           
=======================================
  Hits        42732    42732           
  Misses      19745    19745           
  Partials     1699     1699           
Flag Coverage Δ
javascript 51.31% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.


Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update eab9388...3add8eb. Read the comment docs.

Copy link
Member

@zhaoyongjie zhaoyongjie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! tested in my local.

@villebro villebro merged commit 11bf0d0 into apache:master Apr 1, 2022
@villebro villebro added the lts-v1 label Apr 1, 2022
villebro added a commit that referenced this pull request Apr 3, 2022
villebro added a commit that referenced this pull request Apr 4, 2022
philipher29 pushed a commit to ValtechMobility/superset that referenced this pull request Jun 9, 2022
@mistercrunch mistercrunch added 🍒 1.5.0 🍒 1.5.1 🍒 1.5.2 🍒 1.5.3 🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels 🚢 2.0.0 labels Mar 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels lts-v1 preset-io size/XS 🍒 1.5.0 🍒 1.5.1 🍒 1.5.2 🍒 1.5.3 🚢 2.0.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants