-
Notifications
You must be signed in to change notification settings - Fork 13.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: remove redundant adodbapi warning #19557
chore: remove redundant adodbapi warning #19557
Conversation
Codecov Report
@@ Coverage Diff @@
## master #19557 +/- ##
===========================================
- Coverage 66.59% 53.93% -12.66%
===========================================
Files 1682 1678 -4
Lines 64321 64261 -60
Branches 6561 6561
===========================================
- Hits 42837 34662 -8175
- Misses 19783 27898 +8115
Partials 1701 1701
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
(cherry picked from commit 0d331f5)
SUMMARY
The
adodbapi
dialect appears to be the only dialect included inSQLAlchemy
1.3 that doesn't implement thedbapi()
method, and is fully removed in 1.4. To avoid logging a confusing warning, we should avoid trying to use the driver until we bump to 1.4.BEFORE
Previous to this check, the following would regularly pop up on logs:
TESTING INSTRUCTIONS
Call
http://host/api/v1/database/available/
and make sure the you get the same available drivers as before, but no warning on the logs.ADDITIONAL INFORMATION