Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: spelling of following #19594

Merged
merged 1 commit into from
Apr 8, 2022
Merged

fix: spelling of following #19594

merged 1 commit into from
Apr 8, 2022

Conversation

lzm0
Copy link
Contributor

@lzm0 lzm0 commented Apr 7, 2022

SUMMARY

BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF

TESTING INSTRUCTIONS

ADDITIONAL INFORMATION

  • Has associated issue:
  • Required feature flags:
  • Changes UI
  • Includes DB Migration (follow approval process in SIP-59)
    • Migration is atomic, supports rollback & is backwards-compatible
    • Confirm DB migration upgrade and downgrade tested
    • Runtime estimates and downtime expectations provided
  • Introduces new feature or API
  • Removes existing feature or API

@etr2460 etr2460 changed the title Fix spelling: following fix: spelling of following Apr 7, 2022
@codecov
Copy link

codecov bot commented Apr 7, 2022

Codecov Report

Merging #19594 (74684c5) into master (f91f83d) will decrease coverage by 0.16%.
The diff coverage is n/a.

❗ Current head 74684c5 differs from pull request most recent head 3b0e8a7. Consider uploading reports for the commit 3b0e8a7 to get more accurate results

@@            Coverage Diff             @@
##           master   #19594      +/-   ##
==========================================
- Coverage   66.65%   66.48%   -0.17%     
==========================================
  Files        1680     1680              
  Lines       64292    64292              
  Branches     6564     6564              
==========================================
- Hits        42854    42747     -107     
- Misses      19736    19843     +107     
  Partials     1702     1702              
Flag Coverage Δ
hive ?
mysql 81.89% <ø> (ø)
postgres 81.94% <ø> (ø)
presto ?
python 82.03% <ø> (-0.34%) ⬇️
sqlite 81.71% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
superset/utils/cache_manager.py 100.00% <ø> (ø)
superset/db_engines/hive.py 0.00% <0.00%> (-85.19%) ⬇️
superset/db_engine_specs/hive.py 70.11% <0.00%> (-15.71%) ⬇️
superset/db_engine_specs/presto.py 83.64% <0.00%> (-5.39%) ⬇️
superset/connectors/sqla/models.py 88.24% <0.00%> (-1.22%) ⬇️
superset/db_engine_specs/base.py 88.01% <0.00%> (-0.34%) ⬇️
superset/models/core.py 88.83% <0.00%> (-0.24%) ⬇️
superset/utils/core.py 89.71% <0.00%> (-0.12%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f91f83d...3b0e8a7. Read the comment docs.

@etr2460
Copy link
Member

etr2460 commented Apr 8, 2022

Thanks for the fix!

@etr2460 etr2460 merged commit 8da2c9b into apache:master Apr 8, 2022
philipher29 pushed a commit to ValtechMobility/superset that referenced this pull request Jun 9, 2022
@mistercrunch mistercrunch added 🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels 🚢 2.0.0 labels Mar 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels size/XS 🚢 2.0.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants