Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor(frontend): Make dashboard search box the first filter #19721

Merged
merged 2 commits into from
Dec 7, 2022
Merged

refactor(frontend): Make dashboard search box the first filter #19721

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
f552398
frontend(dashboard): Make search the first filter
cemremengu Apr 14, 2022
3db08f7
move search key
cemremengu Dec 7, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 7 additions & 7 deletions superset-frontend/src/views/CRUD/dashboard/DashboardList.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -463,6 +463,13 @@ function DashboardList(props: DashboardListProps) {

const filters: Filters = useMemo(
() => [
{
Header: t('Search'),
key: 'search',
id: 'dashboard_title',
input: 'search',
operator: FilterOperator.titleOrSlug,
},
{
Header: t('Owner'),
key: 'owner',
Expand Down Expand Up @@ -533,13 +540,6 @@ function DashboardList(props: DashboardListProps) {
{ label: t('No'), value: false },
],
},
{
Header: t('Search'),
key: 'search',
id: 'dashboard_title',
input: 'search',
operator: FilterOperator.titleOrSlug,
},
],
[addDangerToast, favoritesFilter, props.user],
);
Expand Down