Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(chart & explore): Show labels for SliderControl #19765

Merged
merged 3 commits into from
Apr 20, 2022

Conversation

prosdev0107
Copy link
Contributor

@prosdev0107 prosdev0107 commented Apr 18, 2022

SUMMARY

[Charts in explore] Labels are missing for some controls on Customize tab (Graph chart)

BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF

BEFORE:
image

AFTER:
Screenshot-GraphChart

TESTING INSTRUCTIONS

How to reproduce issues

  1. Open a graph chart in explore
  2. Toggle to Customize tab
  3. Pay attention to the controls at the bottom

This issue is happened on some other charts as well as Graph chart

ADDITIONAL INFORMATION

  • Has associated issue:
  • Required feature flags:
  • Changes UI
  • Includes DB Migration (follow approval process in SIP-59)
    • Migration is atomic, supports rollback & is backwards-compatible
    • Confirm DB migration upgrade and downgrade tested
    • Runtime estimates and downtime expectations provided
  • Introduces new feature or API
  • Removes existing feature or API

@codecov
Copy link

codecov bot commented Apr 18, 2022

Codecov Report

Merging #19765 (a5285a7) into master (cf51459) will decrease coverage by 0.16%.
The diff coverage is 66.66%.

❗ Current head a5285a7 differs from pull request most recent head e66dd36. Consider uploading reports for the commit e66dd36 to get more accurate results

@@            Coverage Diff             @@
##           master   #19765      +/-   ##
==========================================
- Coverage   66.51%   66.34%   -0.17%     
==========================================
  Files        1687     1690       +3     
  Lines       64618    64617       -1     
  Branches     6646     6656      +10     
==========================================
- Hits        42978    42871     -107     
- Misses      19940    20045     +105     
- Partials     1700     1701       +1     
Flag Coverage Δ
hive ?
javascript 51.19% <66.66%> (+<0.01%) ⬆️
presto ?

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
superset-frontend/src/components/Chart/Chart.jsx 52.54% <0.00%> (+2.54%) ⬆️
.../src/explore/components/ControlPanelsContainer.tsx 79.80% <ø> (ø)
.../src/explore/components/controls/SliderControl.tsx 0.00% <0.00%> (ø)
superset/db_engine_specs/pinot.py 97.36% <ø> (ø)
superset/reports/api.py 89.84% <ø> (ø)
.../explore/components/ExploreViewContainer/index.jsx 52.29% <10.00%> (-2.60%) ⬇️
...perset-frontend/src/views/CRUD/alert/AlertList.tsx 65.30% <33.33%> (-1.37%) ⬇️
...frontend/src/components/ImportModal/ErrorAlert.tsx 40.00% <40.00%> (ø)
...rset-frontend/src/components/ImportModal/index.tsx 73.17% <50.00%> (+0.67%) ⬆️
...t-frontend/src/explore/components/ExploreAlert.tsx 58.33% <58.33%> (ø)
... and 15 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update cf51459...e66dd36. Read the comment docs.

@rusackas rusackas changed the title fix(chart & explore): make to show label of slidercontrol fix(chart & explore): Show labels for SliderControl Apr 20, 2022
@rusackas rusackas merged commit dfbaba9 into apache:master Apr 20, 2022
villebro pushed a commit that referenced this pull request Apr 25, 2022
* fix(chart & explore): make to show label of slidercontrol

* fix(chart & explore): make to update SliderControl props

* fix(chart & explore): make to fix lint

(cherry picked from commit dfbaba9)
hughhhh pushed a commit to hve-labs/superset that referenced this pull request May 11, 2022
* fix(chart & explore): make to show label of slidercontrol

* fix(chart & explore): make to update SliderControl props

* fix(chart & explore): make to fix lint
philipher29 pushed a commit to ValtechMobility/superset that referenced this pull request Jun 9, 2022
* fix(chart & explore): make to show label of slidercontrol

* fix(chart & explore): make to update SliderControl props

* fix(chart & explore): make to fix lint
@mistercrunch mistercrunch added 🍒 1.5.0 🍒 1.5.1 🍒 1.5.2 🍒 1.5.3 🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels 🚢 2.0.0 labels Mar 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels lts-v1 Preset-Patch size/M 🍒 1.5.0 🍒 1.5.1 🍒 1.5.2 🍒 1.5.3 🚢 2.0.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants