Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: deck.gl GeoJsonLayer Autozoom & fill/stroke options #19778

Conversation

diegomedina248
Copy link
Contributor

SUMMARY

The autozoom feature is not currently working on the GeoJson chart from deck.gl
Also, the fill/stroke options for said plugin are not respected, yielding a black color no matter what option is passed in.

BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF

Before:

Screen.Recording.2022-04-19.at.11.26.18.mov

After:

Screen.Recording.2022-04-19.at.11.23.25.mov

TESTING INSTRUCTIONS

  1. Create a dataset with valid geojson structure (you can use this csv table)
  2. Create a deck.gl geojson visualization
  3. Configure the visualization to use the column with the geojson.
  4. Set to autozoom
  5. Set a fill color

Ensure the map is zoomed to the db features involved with the proper color

ADDITIONAL INFORMATION

  • Has associated issue:
  • Required feature flags:
  • Changes UI
  • Includes DB Migration (follow approval process in SIP-59)
    • Migration is atomic, supports rollback & is backwards-compatible
    • Confirm DB migration upgrade and downgrade tested
    • Runtime estimates and downtime expectations provided
  • Introduces new feature or API
  • Removes existing feature or API

@codecov
Copy link

codecov bot commented Apr 19, 2022

Codecov Report

Merging #19778 (284c309) into master (cf51459) will decrease coverage by 0.01%.
The diff coverage is 60.50%.

❗ Current head 284c309 differs from pull request most recent head eb6f5b7. Consider uploading reports for the commit eb6f5b7 to get more accurate results

@@            Coverage Diff             @@
##           master   #19778      +/-   ##
==========================================
- Coverage   66.51%   66.50%   -0.02%     
==========================================
  Files        1687     1690       +3     
  Lines       64618    64628      +10     
  Branches     6646     6660      +14     
==========================================
  Hits        42978    42978              
- Misses      19940    19949       +9     
- Partials     1700     1701       +1     
Flag Coverage Δ
javascript 51.17% <60.50%> (-0.02%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...preset-chart-deckgl/src/layers/Geojson/Geojson.jsx 0.00% <0.00%> (ø)
...et-chart-deckgl/src/layers/Geojson/controlPanel.ts 50.00% <ø> (ø)
superset-frontend/src/components/Chart/Chart.jsx 52.54% <0.00%> (+2.54%) ⬆️
.../src/explore/components/ControlPanelsContainer.tsx 79.80% <ø> (ø)
superset/reports/api.py 89.84% <ø> (ø)
.../explore/components/ExploreViewContainer/index.jsx 52.29% <10.00%> (-2.60%) ⬇️
...perset-frontend/src/views/CRUD/alert/AlertList.tsx 65.30% <33.33%> (-1.37%) ⬇️
...frontend/src/components/ImportModal/ErrorAlert.tsx 40.00% <40.00%> (ø)
...rset-frontend/src/components/ImportModal/index.tsx 73.17% <50.00%> (+0.67%) ⬆️
...t-frontend/src/explore/components/ExploreAlert.tsx 58.33% <58.33%> (ø)
... and 7 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update cf51459...eb6f5b7. Read the comment docs.

@rusackas
Copy link
Member

/testenv up

@github-actions
Copy link
Contributor

@rusackas Ephemeral environment spinning up at http://54.218.99.137:8080. Credentials are admin/admin. Please allow several minutes for bootstrapping and startup.

@rusackas rusackas merged commit d65b77e into apache:master Apr 26, 2022
@github-actions
Copy link
Contributor

Ephemeral environment shutdown and build artifacts deleted.

hughhhh pushed a commit to hve-labs/superset that referenced this pull request May 11, 2022
* fix: deck.gl GeoJsonLayer Autozoom & fill/stroke options

* fix package.json

* fix lint
philipher29 pushed a commit to ValtechMobility/superset that referenced this pull request Jun 9, 2022
* fix: deck.gl GeoJsonLayer Autozoom & fill/stroke options

* fix package.json

* fix lint
@mistercrunch mistercrunch added 🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels 🚢 2.0.0 labels Mar 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels Preset-Patch size/M 🚢 2.0.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants