-
Notifications
You must be signed in to change notification settings - Fork 13.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: deck.gl GeoJsonLayer Autozoom & fill/stroke options #19778
fix: deck.gl GeoJsonLayer Autozoom & fill/stroke options #19778
Conversation
Codecov Report
@@ Coverage Diff @@
## master #19778 +/- ##
==========================================
- Coverage 66.51% 66.50% -0.02%
==========================================
Files 1687 1690 +3
Lines 64618 64628 +10
Branches 6646 6660 +14
==========================================
Hits 42978 42978
- Misses 19940 19949 +9
- Partials 1700 1701 +1
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
/testenv up |
@rusackas Ephemeral environment spinning up at http://54.218.99.137:8080. Credentials are |
Ephemeral environment shutdown and build artifacts deleted. |
* fix: deck.gl GeoJsonLayer Autozoom & fill/stroke options * fix package.json * fix lint
* fix: deck.gl GeoJsonLayer Autozoom & fill/stroke options * fix package.json * fix lint
SUMMARY
The autozoom feature is not currently working on the GeoJson chart from deck.gl
Also, the fill/stroke options for said plugin are not respected, yielding a black color no matter what option is passed in.
BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF
Before:
Screen.Recording.2022-04-19.at.11.26.18.mov
After:
Screen.Recording.2022-04-19.at.11.23.25.mov
TESTING INSTRUCTIONS
Ensure the map is zoomed to the db features involved with the proper color
ADDITIONAL INFORMATION