Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(filter): make to hide sort filter when time range #19871

Merged
merged 1 commit into from
Apr 27, 2022

Conversation

prosdev0107
Copy link
Contributor

@prosdev0107 prosdev0107 commented Apr 27, 2022

SUMMARY

Hide Sort Filter Values option on Time Range Filters

BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF

BEFORE:
image

AFTER:
I hide the Filter Configuration Section because that there are no sections because that canDependOnOtherFilters and hasDataSet values are both false and sort filter values should be hide in case of that Filter type is Time Range.
image

TESTING INSTRUCTIONS

How to reproduce issue

  1. Go to Dashboard Filter
  2. Select Add/edit Filter
  3. Select Time Range as Filter Type

ADDITIONAL INFORMATION

  • Has associated issue:
  • Required feature flags:
  • Changes UI
  • Includes DB Migration (follow approval process in SIP-59)
    • Migration is atomic, supports rollback & is backwards-compatible
    • Confirm DB migration upgrade and downgrade tested
    • Runtime estimates and downtime expectations provided
  • Introduces new feature or API
  • Removes existing feature or API

@codecov
Copy link

codecov bot commented Apr 27, 2022

Codecov Report

Merging #19871 (1c8a2d6) into master (f9d28a1) will decrease coverage by 0.16%.
The diff coverage is 29.72%.

❗ Current head 1c8a2d6 differs from pull request most recent head 8b1ee30. Consider uploading reports for the commit 8b1ee30 to get more accurate results

@@            Coverage Diff             @@
##           master   #19871      +/-   ##
==========================================
- Coverage   66.48%   66.31%   -0.17%     
==========================================
  Files        1713     1713              
  Lines       64995    64996       +1     
  Branches     6698     6699       +1     
==========================================
- Hits        43209    43103     -106     
- Misses      20079    20186     +107     
  Partials     1707     1707              
Flag Coverage Δ
hive ?
javascript 51.15% <29.72%> (+<0.01%) ⬆️
presto ?

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...onfigModal/FiltersConfigForm/FiltersConfigForm.tsx 59.36% <29.72%> (+0.14%) ⬆️
superset/db_engines/hive.py 0.00% <0.00%> (-85.19%) ⬇️
superset/db_engine_specs/hive.py 70.11% <0.00%> (-15.71%) ⬇️
superset/db_engine_specs/presto.py 83.36% <0.00%> (-5.34%) ⬇️
superset/connectors/sqla/models.py 88.84% <0.00%> (-1.20%) ⬇️
superset/db_engine_specs/base.py 88.01% <0.00%> (-0.34%) ⬇️
superset/models/core.py 89.09% <0.00%> (-0.24%) ⬇️
superset/utils/core.py 89.71% <0.00%> (-0.12%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f9d28a1...8b1ee30. Read the comment docs.

@prosdev0107 prosdev0107 changed the title feature(filter): make to hide sort filter when time range feat(filter): make to hide sort filter when time range Apr 27, 2022
@rusackas rusackas merged commit 59ee029 into apache:master Apr 27, 2022
hughhhh pushed a commit to hve-labs/superset that referenced this pull request May 11, 2022
philipher29 pushed a commit to ValtechMobility/superset that referenced this pull request Jun 9, 2022
@mistercrunch mistercrunch added 🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels 🚢 2.0.0 labels Mar 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels Preset-Patch size/L 🚢 2.0.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants