fix(allow-db-explore): make to check the allow virtual table explore option by default #19883
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #19883 +/- ##
=======================================
Coverage 66.52% 66.52%
=======================================
Files 1714 1714
Lines 65031 65031
Branches 6714 6714
=======================================
Hits 43259 43259
Misses 20065 20065
Partials 1707 1707
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
|
/testenv up |
|
@yousoph Ephemeral environment spinning up at http://34.220.182.132:8080. Credentials are |
Gwitchr
approved these changes
Apr 28, 2022
diegomedina248
approved these changes
Apr 28, 2022
pkdotson
approved these changes
Apr 28, 2022
|
Ephemeral environment shutdown and build artifacts deleted. |
sadpandajoe
pushed a commit
to preset-io/superset
that referenced
this pull request
Apr 29, 2022
…option by default (apache#19883) * fix(db & explore): make to check the allow-db-explore option by default * fix(db-explore): make to remove console.log (cherry picked from commit ea6753d)
|
🏷️ preset:2022.17 |
hughhhh
pushed a commit
to hve-labs/superset
that referenced
this pull request
May 11, 2022
…option by default (apache#19883) * fix(db & explore): make to check the allow-db-explore option by default * fix(db-explore): make to remove console.log
philipher29
pushed a commit
to ValtechMobility/superset
that referenced
this pull request
Jun 9, 2022
…option by default (apache#19883) * fix(db & explore): make to check the allow-db-explore option by default * fix(db-explore): make to remove console.log
mistercrunch
added
🏷️ bot
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SUMMARY
The "Allow this database to be explored" setting should be checked by default in the Database Connection UI.
Description
When creating a new database connection, users are able to control which actions should be allowed on this database:
By default, Allow this database to be explored is un-checked, however this functionality is enabled on the application.
The functionality of Exploring from SQL Lab should match the Database connection UI checkbox. Since the functionality is enabled, the checkbox should be checked by default when creating a new connection.
BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF
BEFORE:
allow-explore.mov
AFTER:
allow-table-explore.mov
TESTING INSTRUCTIONS
How to reproduce the bug
ADDITIONAL INFORMATION