Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Adds the theme object to chart properties #19951

Merged

Conversation

michael-s-molina
Copy link
Member

SUMMARY

This PR adds the theme object to chart properties and adjusts the tests accordingly. This is a prerequisite for applying themes to plugins.

TESTING INSTRUCTIONS

1 - Execute all tests
2 - All tests must pass

ADDITIONAL INFORMATION

  • Has associated issue:
  • Required feature flags:
  • Changes UI
  • Includes DB Migration (follow approval process in SIP-59)
    • Migration is atomic, supports rollback & is backwards-compatible
    • Confirm DB migration upgrade and downgrade tested
    • Runtime estimates and downtime expectations provided
  • Introduces new feature or API
  • Removes existing feature or API

@codecov
Copy link

codecov bot commented May 4, 2022

Codecov Report

Merging #19951 (032a23f) into master (e1f53f2) will decrease coverage by 0.00%.
The diff coverage is 57.44%.

❗ Current head 032a23f differs from pull request most recent head 15204a2. Consider uploading reports for the commit 15204a2 to get more accurate results

@@            Coverage Diff             @@
##           master   #19951      +/-   ##
==========================================
- Coverage   66.53%   66.52%   -0.01%     
==========================================
  Files        1714     1714              
  Lines       65044    65084      +40     
  Branches     6723     6725       +2     
==========================================
+ Hits        43278    43300      +22     
- Misses      20055    20072      +17     
- Partials     1711     1712       +1     
Flag Coverage Δ
javascript 51.25% <43.33%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...perset-ui-core/src/chart/components/SuperChart.tsx 100.00% <ø> (ø)
...frontend/src/SqlLab/components/ResultSet/index.tsx 50.49% <ø> (ø)
...rset-frontend/src/dashboard/util/findPermission.ts 92.30% <ø> (ø)
superset-frontend/src/embedded/index.tsx 0.00% <0.00%> (ø)
...nd/src/explore/components/DataTablesPane/index.tsx 71.55% <ø> (ø)
...nts/ExploreAdditionalActionsMenu/ExploreReport.tsx 57.89% <ø> (ø)
...ntend/src/explore/components/ExploreChartPanel.jsx 70.49% <0.00%> (-1.18%) ⬇️
superset-frontend/src/preamble.ts 0.00% <ø> (ø)
superset-frontend/src/types/bootstrapTypes.ts 100.00% <ø> (ø)
superset/charts/api.py 85.93% <ø> (ø)
... and 17 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e1f53f2...15204a2. Read the comment docs.

Copy link
Member

@villebro villebro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, exciting stuff!

@michael-s-molina michael-s-molina merged commit e9032e9 into apache:master May 4, 2022
jasonvank pushed a commit to CarbonEdge2021/superset that referenced this pull request May 4, 2022
jasonvank pushed a commit to CarbonEdge2021/superset that referenced this pull request May 4, 2022
hughhhh pushed a commit to hve-labs/superset that referenced this pull request May 11, 2022
philipher29 pushed a commit to ValtechMobility/superset that referenced this pull request Jun 9, 2022
@mistercrunch mistercrunch added 🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels 🚢 2.0.0 labels Mar 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels size/L 🚢 2.0.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants