Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(SQL Lab): Make SQL Lab explore use the default viz from the config file #20056

Merged
merged 9 commits into from
Jun 22, 2022
Merged

feat(SQL Lab): Make SQL Lab explore use the default viz from the config file #20056

Show file tree
Hide file tree
Changes from 3 commits
Commits
Show all changes
9 commits
Select commit Hold shift + click to select a range
d0c7806
Modified SQL Lab so it uses the default viz to explore a new dataset …
cccs-Dustin May 12, 2022
500512d
Added a comment to the config file
cccs-Dustin May 13, 2022
746ca1f
Remove trailing whitespace
cccs-Dustin May 13, 2022
71c0130
[CLDN-1312] Removed the 'viz_type' variable so that when it is undefi…
cccs-Dustin May 27, 2022
40b4d2a
[CLDN-1312] Only sets the 'all_columns' variable if the default viz t…
cccs-Dustin May 27, 2022
dc14ee1
Will only pop 'selectedColumns' out of 'form_data' if it is present
cccs-Dustin May 30, 2022
2239663
[CLDN-1312] Merge branch with most recent version of master
cccs-Dustin Jun 8, 2022
210ab09
[CLDN-1312] Updated files so that the default viz is now being used a…
cccs-Dustin Jun 8, 2022
32395da
Merge branch 'master' into feature/CLDN-1312
cccs-Dustin Jun 22, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion superset-frontend/src/SqlLab/components/ResultSet/index.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -343,7 +343,7 @@ export default class ResultSet extends React.PureComponent<
metrics: [],
groupby: [],
time_range: 'No filter',
viz_type: 'table',
viz_type: '',
rusackas marked this conversation as resolved.
Show resolved Hide resolved
all_columns: selectedColumns.map(c => c.name),
cccs-Dustin marked this conversation as resolved.
Show resolved Hide resolved
row_limit: 1000,
});
Expand Down
2 changes: 1 addition & 1 deletion superset/config.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -130,7 +130,7 @@ def _try_json_readsha(filepath: str, length: int) -> Optional[str]:
# can be replaced at build time to expose build information.
BUILD_NUMBER = None

# default viz used in chart explorer
# default viz used in chart explorer & SQL Lab explore
DEFAULT_VIZ_TYPE = "table"

# default row limit when requesting chart data
Expand Down
3 changes: 3 additions & 0 deletions superset/views/core.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -834,6 +834,9 @@ def explore(
if not viz_type and datasource and datasource.default_endpoint:
return redirect(datasource.default_endpoint)

if form_data.get("viz_type") == "":
form_data["viz_type"] = app.config["DEFAULT_VIZ_TYPE"]

# slc perms
slice_add_perm = security_manager.can_access("can_write", "Chart")
slice_overwrite_perm = is_owner(slc, g.user) if slc else False
Expand Down