-
Notifications
You must be signed in to change notification settings - Fork 13.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: Bad date type in email text report for table chart #20119
fix: Bad date type in email text report for table chart #20119
Conversation
Codecov Report
@@ Coverage Diff @@
## master #20119 +/- ##
==========================================
+ Coverage 66.47% 66.55% +0.07%
==========================================
Files 1727 1729 +2
Lines 64724 64936 +212
Branches 6822 6794 -28
==========================================
+ Hits 43024 43216 +192
- Misses 19969 19992 +23
+ Partials 1731 1728 -3
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
/testenv up |
@yousoph Ephemeral environment spinning up at http://34.219.71.53:8080. Credentials are |
@eschutho do you have a convenient means of testing this PR? Not sure how to test on the ephemeral envs. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good, do you mind writing a test where it converts the datetime?
@rusackas unfortunately, no, we can't test reports on ephemeral but I can pull it down locally and test if that helps. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
Ephemeral environment shutdown and build artifacts deleted. |
* fix bad date type in email text report for table chart * fix test, pylint issue * add test case for date type
SUMMARY
When creating a report that sends a table chart with dates, and choose the option send by email as text, the dates show badly formatted
It is because
/api/v1/chart/data
endpoint returns datetime64 data which represents as milliseconds.Need to convert is as date type when we create pandas Dataframe from the result data.
BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF
BEFORE:
AFTER:
TESTING INSTRUCTIONS
ADDITIONAL INFORMATION