-
Notifications
You must be signed in to change notification settings - Fork 13.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore(requirements): Cleanup of Python requirements #20154
chore(requirements): Cleanup of Python requirements #20154
Conversation
@@ -15,10 +15,5 @@ | |||
# KIND, either express or implied. See the License for the | |||
# specific language governing permissions and limitations | |||
# under the License. | |||
# |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Consistency.
500a140
to
72e7dba
Compare
Codecov Report
@@ Coverage Diff @@
## master #20154 +/- ##
===========================================
- Coverage 66.41% 54.56% -11.85%
===========================================
Files 1726 1721 -5
Lines 64736 64513 -223
Branches 6826 6806 -20
===========================================
- Hits 42993 35204 -7789
- Misses 20010 27577 +7567
+ Partials 1733 1732 -1
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
72e7dba
to
d8f6a75
Compare
docker | ||
flask-testing | ||
freezegun | ||
google-cloud-bigquery | ||
ipdb | ||
# pinning ipython as pip-compile-multi was bringing higher version |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Erroneous comment.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice clear-up. Thanks!
SUMMARY
As titled. Cleaning up the Python requirements (w/o bumping). The change removes unnecessary inclusions and leverages the
. -e[...]
format to include extras by adhering to the DRY principle which should help reduce the level of maintenance.The change was made via,
BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF
TESTING INSTRUCTIONS
CI.
ADDITIONAL INFORMATION