-
Notifications
You must be signed in to change notification settings - Fork 13.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: bumping min version of shillelagh #20196
Conversation
Codecov Report
@@ Coverage Diff @@
## master #20196 +/- ##
===========================================
- Coverage 66.43% 54.36% -12.07%
===========================================
Files 1722 1727 +5
Lines 64640 64721 +81
Branches 6822 6823 +1
===========================================
- Hits 42944 35188 -7756
- Misses 19962 27801 +7839
+ Partials 1734 1732 -2
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
did you run pip-compile-multi on this? |
@eschutho no, but I don't think that you need to because shillelagh isn't on the list of required installs in the superset's setup.py. I think it is worth it to have it at the latest working version of shillelagh though so that people who are installing shillelagh have the current working version. |
@eschutho ran pip-compile-multi --no-upgrade on this |
12beb65
to
101abfb
Compare
* bumping min version of shillelagh * ran pip-compile-multi
SUMMARY
This bumps the minimum version of shillelagh to a higher minimum version to account for releases that have fixed some bugs with creating google sheets.
BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF
TESTING INSTRUCTIONS
ADDITIONAL INFORMATION