Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(explore): Denormalize form data in echarts, world map and nvd3 bar and line charts #20313

Merged
merged 3 commits into from
Jun 9, 2022

Conversation

kgabryje
Copy link
Member

@kgabryje kgabryje commented Jun 8, 2022

SUMMARY

Applies denormalization introduced in #20010 to following charts:

  • World map
  • nvd3:
    • Line
    • Bar
    • Timeseries bar
  • Echarts:
    • Mixed series
    • Box plot
    • Funnel
    • Gauge
    • Graph
    • Radar
    • Area
    • Generic series
    • Bar
    • Smooth line
    • Scatter
    • Step
    • Tree
    • Treemap

BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF

TESTING INSTRUCTIONS

Listed charts should work like described in #20010

ADDITIONAL INFORMATION

  • Has associated issue:
  • Required feature flags:
  • Changes UI
  • Includes DB Migration (follow approval process in SIP-59)
    • Migration is atomic, supports rollback & is backwards-compatible
    • Confirm DB migration upgrade and downgrade tested
    • Runtime estimates and downtime expectations provided
  • Introduces new feature or API
  • Removes existing feature or API

@codecov
Copy link

codecov bot commented Jun 8, 2022

Codecov Report

Merging #20313 (e2d2442) into master (2a45be3) will decrease coverage by 0.06%.
The diff coverage is 0.00%.

@@            Coverage Diff             @@
##           master   #20313      +/-   ##
==========================================
- Coverage   66.65%   66.58%   -0.07%     
==========================================
  Files        1729     1733       +4     
  Lines       64910    64978      +68     
  Branches     6842     6858      +16     
==========================================
+ Hits        43267    43268       +1     
- Misses      19894    19955      +61     
- Partials     1749     1755       +6     
Flag Coverage Δ
javascript 51.47% <0.00%> (-0.11%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
.../legacy-plugin-chart-world-map/src/controlPanel.ts 25.00% <0.00%> (-8.34%) ⬇️
...s/legacy-preset-chart-nvd3/src/Bar/controlPanel.ts 14.28% <0.00%> (-2.39%) ⬇️
...gacy-preset-chart-nvd3/src/DistBar/controlPanel.ts 8.33% <0.00%> (-2.78%) ⬇️
.../legacy-preset-chart-nvd3/src/Line/controlPanel.ts 50.00% <0.00%> (-50.00%) ⬇️
...s/plugin-chart-echarts/src/BoxPlot/controlPanel.ts 25.00% <0.00%> (-75.00%) ⬇️
...s/plugin-chart-echarts/src/Funnel/controlPanel.tsx 66.66% <0.00%> (-13.34%) ⬇️
...ns/plugin-chart-echarts/src/Gauge/controlPanel.tsx 66.66% <0.00%> (-33.34%) ⬇️
...ns/plugin-chart-echarts/src/Graph/controlPanel.tsx 21.42% <0.00%> (-1.65%) ⬇️
...chart-echarts/src/MixedTimeseries/controlPanel.tsx 65.00% <ø> (-21.67%) ⬇️
...ns/plugin-chart-echarts/src/Radar/controlPanel.tsx 27.27% <0.00%> (-2.73%) ⬇️
... and 35 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2a45be3...e2d2442. Read the comment docs.

Copy link
Member

@stephenLYZ stephenLYZ left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM with one nit.

@@ -210,6 +210,11 @@ const config: ControlPanelConfig = {
],
},
],
denormalizeFormData: formData => ({
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It looks like the denormalizeFormData is consistent for most charts, so maybe we can abstract out a generic function?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Different viz have different control names, for example, the BigNumber supported 1 metric and 0 dimension, the metrics in SFD should pick only one, and drop other columns.

Copy link
Member

@zhaoyongjie zhaoyongjie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great!

@kgabryje kgabryje merged commit 354a899 into apache:master Jun 9, 2022
@mistercrunch mistercrunch added 🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels 🚢 2.0.0 labels Mar 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels preset-io size/L 🚢 2.0.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants