Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Updates control panel font size in Explore #20510

Merged

Conversation

michael-s-molina
Copy link
Member

SUMMARY

Updates control panel font size in Explore. Changes the font-size to 14px and line-height to 1.3 according to design specifications.

@kasiazjc

BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF

Screen Shot 2022-06-27 at 11 48 45 AM

Screen Shot 2022-06-27 at 11 48 05 AM

TESTING INSTRUCTIONS

1 - Go to Explore
2 - Check the new font sizes

ADDITIONAL INFORMATION

  • Has associated issue:
  • Required feature flags:
  • Changes UI
  • Includes DB Migration (follow approval process in SIP-59)
    • Migration is atomic, supports rollback & is backwards-compatible
    • Confirm DB migration upgrade and downgrade tested
    • Runtime estimates and downtime expectations provided
  • Introduces new feature or API
  • Removes existing feature or API

@codecov
Copy link

codecov bot commented Jun 27, 2022

Codecov Report

Merging #20510 (fb452ed) into master (f29cde2) will increase coverage by 0.00%.
The diff coverage is 100.00%.

❗ Current head fb452ed differs from pull request most recent head e4a27e2. Consider uploading reports for the commit e4a27e2 to get more accurate results

@@           Coverage Diff           @@
##           master   #20510   +/-   ##
=======================================
  Coverage   66.85%   66.85%           
=======================================
  Files        1749     1749           
  Lines       65411    65412    +1     
  Branches     6906     6906           
=======================================
+ Hits        43730    43731    +1     
  Misses      19931    19931           
  Partials     1750     1750           
Flag Coverage Δ
javascript 51.84% <100.00%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
.../src/explore/components/ControlPanelsContainer.tsx 80.00% <100.00%> (+0.19%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f29cde2...e4a27e2. Read the comment docs.

Copy link
Member

@kgabryje kgabryje left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@michael-s-molina michael-s-molina merged commit 480ee38 into apache:master Jun 28, 2022
@kasiazjc
Copy link
Contributor

Sorry, missed that one! Will the headers in the metrics&columns panel updated in the different PR? I think I also added those ones to fix for the consistency 👀

@michael-s-molina
Copy link
Member Author

the headers in the metrics&columns panel updated in the different PR? I think I also added those ones to fix for the consistency 👀

Yes. I'll fix them in a separate PR.

akshatsri pushed a commit to charan1314/superset that referenced this pull request Jul 19, 2022
@mistercrunch mistercrunch added 🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels 🚢 2.1.0 labels Mar 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels size/XS 🚢 2.1.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants