Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(explore): Apply denormalization to tier 2 charts form data #20524

Merged
merged 10 commits into from
Jun 28, 2022

Conversation

kgabryje
Copy link
Member

SUMMARY

This PR enables following charts to use the standardized form data feature:

  • Bubble chart
  • Calendar heatmap
  • Chord diagram
  • Timeseries percent change
  • Country map
  • Handlebars
  • Heatmap
  • Histogram

BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF

TESTING INSTRUCTIONS

Make sure that when you're switching between charts listed above and tier 1 charts (all echarts, table, pivot table, line chart) the metrics and dimensions are persisted and auto-populated.

ADDITIONAL INFORMATION

  • Has associated issue:
  • Required feature flags:
  • Changes UI
  • Includes DB Migration (follow approval process in SIP-59)
    • Migration is atomic, supports rollback & is backwards-compatible
    • Confirm DB migration upgrade and downgrade tested
    • Runtime estimates and downtime expectations provided
  • Introduces new feature or API
  • Removes existing feature or API

Copy link
Member

@zhaoyongjie zhaoyongjie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

Copy link
Member

@stephenLYZ stephenLYZ left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@codecov
Copy link

codecov bot commented Jun 28, 2022

Codecov Report

Merging #20524 (556cacc) into master (c348a09) will decrease coverage by 0.01%.
The diff coverage is 0.00%.

❗ Current head 556cacc differs from pull request most recent head db6f5c0. Consider uploading reports for the commit db6f5c0 to get more accurate results

@@            Coverage Diff             @@
##           master   #20524      +/-   ##
==========================================
- Coverage   66.86%   66.84%   -0.02%     
==========================================
  Files        1751     1751              
  Lines       65429    65440      +11     
  Branches     6912     6912              
==========================================
  Hits        43746    43746              
- Misses      19934    19945      +11     
  Partials     1749     1749              
Flag Coverage Δ
javascript 51.84% <0.00%> (-0.02%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...chart-controls/src/shared-controls/dndControls.tsx 28.30% <ø> (ø)
...hart-controls/src/utils/getStandardizedControls.ts 90.00% <0.00%> (-10.00%) ⬇️
...s/legacy-plugin-chart-calendar/src/controlPanel.ts 50.00% <0.00%> (-50.00%) ⬇️
...gins/legacy-plugin-chart-chord/src/controlPanel.ts 25.00% <0.00%> (-75.00%) ⬇️
...egacy-plugin-chart-country-map/src/controlPanel.ts 50.00% <0.00%> (-50.00%) ⬇️
...ns/legacy-plugin-chart-heatmap/src/controlPanel.ts 57.14% <0.00%> (-9.53%) ⬇️
.../legacy-plugin-chart-histogram/src/controlPanel.ts 50.00% <0.00%> (-10.00%) ⬇️
...egacy-preset-chart-nvd3/src/Bubble/controlPanel.ts 50.00% <0.00%> (-50.00%) ⬇️
...gacy-preset-chart-nvd3/src/Compare/controlPanel.ts 50.00% <0.00%> (-50.00%) ⬇️
...lugin-chart-handlebars/src/plugin/controlPanel.tsx 66.66% <0.00%> (-33.34%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c348a09...db6f5c0. Read the comment docs.

@kgabryje kgabryje merged commit e12ee59 into apache:master Jun 28, 2022
akshatsri pushed a commit to charan1314/superset that referenced this pull request Jul 19, 2022
…he#20524)

* feat(explore): Denormalize form data in Calendar Heatmap

* feat(explore): Denormalize form data in Bubble

* feat(explore): Denormalize form data in Chord

* Dimensions -> Dimension for single selection

* feat(explore): Denormalize form data in Country Map

* feat(explore): Denormalize form data in Heatmap

* feat(explore): Denormalize form data in Histogram

* feat(explore): Denormalize form data in Handlebars

* feat(explore): Denormalize form data in Percent Change

* Use new standardized form data interface
@mistercrunch mistercrunch added 🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels 🚢 2.1.0 labels Mar 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels preset-io size/M 🚢 2.1.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants