-
Notifications
You must be signed in to change notification settings - Fork 13.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(explore): Apply denormalization to tier 2 charts form data #20524
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
a486184
to
db6f5c0
Compare
Codecov Report
@@ Coverage Diff @@
## master #20524 +/- ##
==========================================
- Coverage 66.86% 66.84% -0.02%
==========================================
Files 1751 1751
Lines 65429 65440 +11
Branches 6912 6912
==========================================
Hits 43746 43746
- Misses 19934 19945 +11
Partials 1749 1749
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
…he#20524) * feat(explore): Denormalize form data in Calendar Heatmap * feat(explore): Denormalize form data in Bubble * feat(explore): Denormalize form data in Chord * Dimensions -> Dimension for single selection * feat(explore): Denormalize form data in Country Map * feat(explore): Denormalize form data in Heatmap * feat(explore): Denormalize form data in Histogram * feat(explore): Denormalize form data in Handlebars * feat(explore): Denormalize form data in Percent Change * Use new standardized form data interface
SUMMARY
This PR enables following charts to use the standardized form data feature:
BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF
TESTING INSTRUCTIONS
Make sure that when you're switching between charts listed above and tier 1 charts (all echarts, table, pivot table, line chart) the metrics and dimensions are persisted and auto-populated.
ADDITIONAL INFORMATION