Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Removes psycopg2 as a required dependency #20543

Merged

Conversation

michael-s-molina
Copy link
Member

@michael-s-molina michael-s-molina commented Jun 29, 2022

SUMMARY

Removes psycopg2 as a required dependency in superset/db_engine_specs/postgres.py

TESTING INSTRUCTIONS

1 - Execute all tests
2 - All tests should pass

ADDITIONAL INFORMATION

  • Has associated issue:
  • Required feature flags:
  • Changes UI
  • Includes DB Migration (follow approval process in SIP-59)
    • Migration is atomic, supports rollback & is backwards-compatible
    • Confirm DB migration upgrade and downgrade tested
    • Runtime estimates and downtime expectations provided
  • Introduces new feature or API
  • Removes existing feature or API

@codecov
Copy link

codecov bot commented Jun 29, 2022

Codecov Report

Merging #20543 (290f7c0) into master (4eb2a6f) will decrease coverage by 11.83%.
The diff coverage is 0.00%.

❗ Current head 290f7c0 differs from pull request most recent head a87aa43. Consider uploading reports for the commit a87aa43 to get more accurate results

@@             Coverage Diff             @@
##           master   #20543       +/-   ##
===========================================
- Coverage   66.84%   55.00%   -11.84%     
===========================================
  Files        1752     1752               
  Lines       65447    65447               
  Branches     6912     6912               
===========================================
- Hits        43746    36000     -7746     
- Misses      19952    27698     +7746     
  Partials     1749     1749               
Flag Coverage Δ
hive 53.77% <0.00%> (-0.01%) ⬇️
mysql ?
postgres ?
presto 53.63% <0.00%> (-0.01%) ⬇️
python 58.40% <0.00%> (-24.51%) ⬇️
sqlite ?
unit 50.66% <0.00%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
superset/db_engine_specs/postgres.py 58.47% <0.00%> (-38.14%) ⬇️
superset/utils/dashboard_import_export.py 0.00% <0.00%> (-100.00%) ⬇️
superset/key_value/commands/upsert.py 0.00% <0.00%> (-89.59%) ⬇️
superset/key_value/commands/update.py 0.00% <0.00%> (-89.37%) ⬇️
superset/key_value/commands/delete.py 0.00% <0.00%> (-85.30%) ⬇️
superset/key_value/commands/delete_expired.py 0.00% <0.00%> (-80.77%) ⬇️
superset/dashboards/commands/importers/v0.py 15.62% <0.00%> (-76.25%) ⬇️
superset/datasets/commands/update.py 25.88% <0.00%> (-68.24%) ⬇️
superset/datasets/commands/create.py 30.18% <0.00%> (-67.93%) ⬇️
superset/datasets/commands/importers/v0.py 24.03% <0.00%> (-67.45%) ⬇️
... and 276 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4eb2a6f...a87aa43. Read the comment docs.

Copy link
Member

@zhaoyongjie zhaoyongjie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks for the fixing. psycopy2-binary is not in the dependency list.

@michael-s-molina michael-s-molina merged commit cb3cd41 into apache:master Jun 29, 2022
michael-s-molina added a commit that referenced this pull request Jun 29, 2022
* fix: Removes psycopg2 as a required dependency

* Disables lint warning

(cherry picked from commit cb3cd41)
john-bodley pushed a commit to airbnb/superset-fork that referenced this pull request Jul 8, 2022
* fix: Removes psycopg2 as a required dependency

* Disables lint warning

(cherry picked from commit cb3cd41)
@mistercrunch mistercrunch added 🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels 🚢 2.1.0 and removed 🚢 2.1.3 labels Mar 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels size/XS v2.0 🍒 2.0.0 🍒 2.0.1 🚢 2.1.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants