-
Notifications
You must be signed in to change notification settings - Fork 13.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: Removes psycopg2 as a required dependency #20543
fix: Removes psycopg2 as a required dependency #20543
Conversation
Codecov Report
@@ Coverage Diff @@
## master #20543 +/- ##
===========================================
- Coverage 66.84% 55.00% -11.84%
===========================================
Files 1752 1752
Lines 65447 65447
Branches 6912 6912
===========================================
- Hits 43746 36000 -7746
- Misses 19952 27698 +7746
Partials 1749 1749
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thanks for the fixing. psycopy2-binary is not in the dependency list.
* fix: Removes psycopg2 as a required dependency * Disables lint warning (cherry picked from commit cb3cd41)
* fix: Removes psycopg2 as a required dependency * Disables lint warning (cherry picked from commit cb3cd41)
SUMMARY
Removes
psycopg2
as a required dependency insuperset/db_engine_specs/postgres.py
TESTING INSTRUCTIONS
1 - Execute all tests
2 - All tests should pass
ADDITIONAL INFORMATION