Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(releases): docker build on M1 npm run build fails #20700

Merged
merged 1 commit into from
Jul 13, 2022
Merged

fix(releases): docker build on M1 npm run build fails #20700

merged 1 commit into from
Jul 13, 2022

Conversation

dpgaspar
Copy link
Member

SUMMARY

On M1 testing releases with ./test_run_tarball.sh fails with:

#17 121.9 npm ERR! path /home/superset/apache-superset-2.0.0rc2/superset-frontend/node_modules/puppeteer
#17 121.9 npm ERR! command failed
#17 121.9 npm ERR! command sh -c node install.js
#17 121.9 npm ERR! The chromium binary is not available for arm64.
#17 121.9 npm ERR! If you are on Ubuntu, you can install with:
#17 121.9 npm ERR!
#17 121.9 npm ERR!  sudo apt install chromium
#17 121.9 npm ERR!
#17 121.9 npm ERR!
#17 121.9 npm ERR!  sudo apt install chromium-browser
#17 121.9 npm ERR!
#17 121.9 npm ERR! /home/superset/apache-superset-2.0.0rc2/superset-frontend/node_modules/puppeteer/lib/cjs/puppeteer/node/BrowserFetcher.js:115
#17 121.9 npm ERR!                     throw new Error();
#17 121.9 npm ERR!                     ^
#17 121.9 npm ERR!
#17 121.9 npm ERR! Error
#17 121.9 npm ERR!     at /home/superset/apache-superset-2.0.0rc2/superset-frontend/node_modules/puppeteer/lib/cjs/puppeteer/node/BrowserFetcher.js:115:27
#17 121.9 npm ERR!     at FSReqCallback.oncomplete (node:fs:198:21)

BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF

TESTING INSTRUCTIONS

ADDITIONAL INFORMATION

  • Has associated issue:
  • Required feature flags:
  • Changes UI
  • Includes DB Migration (follow approval process in SIP-59)
    • Migration is atomic, supports rollback & is backwards-compatible
    • Confirm DB migration upgrade and downgrade tested
    • Runtime estimates and downtime expectations provided
  • Introduces new feature or API
  • Removes existing feature or API

dpgaspar
dpgaspar commented Jul 13, 2022
View reviewed changes
RELEASING/test_run_tarball.sh
@@ -26,7 +26,7 @@ if [ -z "${SUPERSET_SVN_DEV_PATH}" ]; then
SUPERSET_SVN_DEV_PATH="$HOME/svn/superset_dev"
fi

if [ ${1} == "local" ]; then
if [[ -n ${1} ]] && [[ ${1} == "local" ]]; then
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

fixes ./test_run_tarball.sh: line 29: [: ==: unary operator expected

dpgaspar
dpgaspar commented Jul 13, 2022
View reviewed changes
RELEASING/Dockerfile.from_local_tarball
@@ -30,7 +30,7 @@ RUN apt-get install -y apt-transport-https apt-utils
# Install superset dependencies
# https://superset.apache.org/docs/installation/installing-superset-from-scratch
RUN apt-get install -y build-essential libssl-dev \
libffi-dev python3-dev libsasl2-dev libldap2-dev libxi-dev
libffi-dev python3-dev libsasl2-dev libldap2-dev libxi-dev chromium
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

could be more defensive and add an extra line with:

RUN if [ $(arch) == "aarch64" ]; then apt-get install chromium; fi

But would add another layer to the container and it should be fine on non M1 also

michael-s-molina
michael-s-molina approved these changes Jul 13, 2022
View reviewed changes
Copy link
Member

@michael-s-molina michael-s-molina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks for the fix!

@dpgaspar dpgaspar merged commit e6b0141 into apache:master Jul 13, 2022
@dpgaspar dpgaspar deleted the fix/releases-for-m1 branch July 13, 2022 22:53
@mistercrunch mistercrunch added 🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels 🚢 2.1.0 labels Mar 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@michael-s-molina michael-s-molina michael-s-molina approved these changes

Assignees
No one assigned
Labels
🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels size/XS 🚢 2.1.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@dpgaspar @michael-s-molina @mistercrunch