-
Notifications
You must be signed in to change notification settings - Fork 13.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: Timeseries visualization with Chart Source = Query #20795
Conversation
Codecov Report
@@ Coverage Diff @@
## master #20795 +/- ##
===========================================
- Coverage 66.28% 54.81% -11.48%
===========================================
Files 1756 1756
Lines 66756 66760 +4
Branches 7049 7059 +10
===========================================
- Hits 44252 36594 -7658
- Misses 20708 28368 +7660
- Partials 1796 1798 +2
Flags with carried forward coverage won't be shown. Click here to find out more.
Help us with your feedback. Take ten seconds to tell us how you rate us. |
) | ||
if isinstance(dttm_col, dict): | ||
timestamp = self.get_timestamp_expression( | ||
dttm_col, time_grain, template_processor |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
does this need the variable declaration that the below function has?
) | ||
if isinstance(col_obj, dict): | ||
sqla_col = self.get_timestamp_expression( | ||
col_obj, time_grain, template_processor |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
same question here.
SUMMARY
Fix issue with running timeseries queries with chart source. Needed to create a new function
get_timestamp_expression
to handle dict vs. objectsBEFORE/AFTER SCREENSHOTS OR ANIMATED GIF
TESTING INSTRUCTIONS
ADDITIONAL INFORMATION