-
Notifications
You must be signed in to change notification settings - Fork 13.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(plugin-chart-echarts): xAxis of bar chart overflow #20805
Conversation
2d7ce05
to
910c5a0
Compare
Codecov Report
@@ Coverage Diff @@
## master #20805 +/- ##
==========================================
- Coverage 66.30% 66.29% -0.02%
==========================================
Files 1756 1758 +2
Lines 66735 66809 +74
Branches 7049 7058 +9
==========================================
+ Hits 44251 44288 +37
- Misses 20688 20720 +32
- Partials 1796 1801 +5
Flags with carried forward coverage won't be shown. Click here to find out more.
Help us with your feedback. Take ten seconds to tell us how you rate us. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@stephenLYZ I don't know if echart can set xaxis to "discrete axis" instead of "continuous variable axis". This problem may be caused by the wrong type of axis.
910c5a0
to
eb2d15d
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
SUMMARY
When the type of xAxis is
value
, some scenarios may cause an overflow problem due to it cannot display all x-axis contents. In this case, we treat this as acategory
.BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF
before
after
TESTING INSTRUCTIONS
ADDITIONAL INFORMATION