Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: remove element reference in alerts report fetchs #20830

Merged
merged 1 commit into from
Jul 22, 2022

Conversation

hughhhh
Copy link
Member

@hughhhh hughhhh commented Jul 22, 2022

SUMMARY

Remove bad reference we is flooding logs with "Failed taking a screenshot local variable 'element' referenced before assignment"

BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF

TESTING INSTRUCTIONS

ADDITIONAL INFORMATION

  • Has associated issue:
  • Required feature flags:
  • Changes UI
  • Includes DB Migration (follow approval process in SIP-59)
    • Migration is atomic, supports rollback & is backwards-compatible
    • Confirm DB migration upgrade and downgrade tested
    • Runtime estimates and downtime expectations provided
  • Introduces new feature or API
  • Removes existing feature or API

@codecov
Copy link

codecov bot commented Jul 22, 2022

Codecov Report

Merging #20830 (31a544e) into master (6e0ddcf) will decrease coverage by 0.19%.
The diff coverage is n/a.

❗ Current head 31a544e differs from pull request most recent head dcb4a23. Consider uploading reports for the commit dcb4a23 to get more accurate results

@@            Coverage Diff             @@
##           master   #20830      +/-   ##
==========================================
- Coverage   66.34%   66.14%   -0.20%     
==========================================
  Files        1756     1756              
  Lines       66748    66747       -1     
  Branches     7059     7059              
==========================================
- Hits        44283    44153     -130     
- Misses      20667    20796     +129     
  Partials     1798     1798              
Flag Coverage Δ
hive ?
mysql 81.08% <ø> (+<0.01%) ⬆️
postgres 81.15% <ø> (+<0.01%) ⬆️
presto ?
python 81.20% <ø> (-0.40%) ⬇️
sqlite ?
unit ?

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
superset/utils/webdriver.py 79.54% <ø> (+0.89%) ⬆️
superset/db_engines/hive.py 0.00% <0.00%> (-85.19%) ⬇️
superset/db_engine_specs/hive.py 70.22% <0.00%> (-15.65%) ⬇️
superset/db_engine_specs/sqlite.py 91.89% <0.00%> (-5.41%) ⬇️
superset/db_engine_specs/presto.py 83.64% <0.00%> (-5.39%) ⬇️
superset/utils/celery.py 86.20% <0.00%> (-3.45%) ⬇️
superset/connectors/sqla/utils.py 86.36% <0.00%> (-2.28%) ⬇️
superset/initialization/__init__.py 89.93% <0.00%> (-1.74%) ⬇️
superset/result_set.py 96.24% <0.00%> (-1.51%) ⬇️
superset/connectors/sqla/models.py 89.20% <0.00%> (-1.15%) ⬇️
... and 4 more

Help us with your feedback. Take ten seconds to tell us how you rate us.

@hughhhh hughhhh merged commit 2263a76 into apache:master Jul 22, 2022
sadpandajoe pushed a commit to preset-io/superset that referenced this pull request Jul 25, 2022
@sadpandajoe
Copy link
Member

🏷️ preset:2022.29

eschutho pushed a commit that referenced this pull request Sep 27, 2022
(cherry picked from commit 2263a76)
AAfghahi pushed a commit that referenced this pull request Oct 5, 2022
(cherry picked from commit 2263a76)
zhaorui2022 pushed a commit to zhaorui2022/superset that referenced this pull request Oct 6, 2022
AAfghahi pushed a commit that referenced this pull request Oct 6, 2022
(cherry picked from commit 2263a76)
Fahrenheit35 pushed a commit to Fahrenheit35/superset that referenced this pull request Nov 11, 2022
@mistercrunch mistercrunch added 🍒 2.0.1 🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels 🚢 2.1.0 and removed 🚢 2.1.3 labels Mar 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels size/XS v2.0 v2.0.1 🍒 2.0.1 🚢 2.1.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants