Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add 'dashboard.nav.right' extension to registry #20835

Merged
merged 2 commits into from
Aug 4, 2022

Conversation

samtfm
Copy link
Contributor

@samtfm samtfm commented Jul 22, 2022

SUMMARY

Adds a extension point to the right side of the dashboard nav

BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF

TESTING INSTRUCTIONS

ADDITIONAL INFORMATION

  • Has associated issue:
  • Required feature flags:
  • Changes UI
  • Includes DB Migration (follow approval process in SIP-59)
    • Migration is atomic, supports rollback & is backwards-compatible
    • Confirm DB migration upgrade and downgrade tested
    • Runtime estimates and downtime expectations provided
  • Introduces new feature or API
  • Removes existing feature or API

@samtfm samtfm changed the title add 'dashboard.nav.right' extension to registry feat: add 'dashboard.nav.right' extension to registry Jul 27, 2022
@samtfm samtfm marked this pull request as ready for review August 2, 2022 19:14
@samtfm samtfm force-pushed the samtfm/add-dashboard-nav-extension branch from 5d0bf06 to 2e87196 Compare August 2, 2022 19:32
@pull-request-size pull-request-size bot added size/M and removed size/S labels Aug 2, 2022
@samtfm samtfm force-pushed the samtfm/add-dashboard-nav-extension branch from 2e87196 to a25e0c7 Compare August 2, 2022 19:48
@codecov
Copy link

codecov bot commented Aug 2, 2022

Codecov Report

Merging #20835 (a25e0c7) into master (1101922) will increase coverage by 0.03%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##           master   #20835      +/-   ##
==========================================
+ Coverage   66.20%   66.24%   +0.03%     
==========================================
  Files        1754     1764      +10     
  Lines       66678    66970     +292     
  Branches     7049     7130      +81     
==========================================
+ Hits        44143    44363     +220     
- Misses      20738    20783      +45     
- Partials     1797     1824      +27     
Flag Coverage Δ
javascript 52.12% <100.00%> (+0.19%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...set-ui-core/src/ui-overrides/ExtensionsRegistry.ts 100.00% <ø> (ø)
...frontend/src/dashboard/components/Header/index.jsx 60.29% <100.00%> (+0.89%) ⬆️
...t-frontend/src/dashboard/containers/SliceAdder.jsx 0.00% <0.00%> (-100.00%) ⬇️
...rontend/src/dashboard/containers/DashboardGrid.jsx 0.00% <0.00%> (-100.00%) ⬇️
superset-frontend/src/featureFlags.ts 66.66% <0.00%> (-33.34%) ⬇️
...components/DashboardBuilder/DashboardContainer.tsx 40.00% <0.00%> (-32.23%) ⬇️
...nd/src/dashboard/util/activeAllDashboardFilters.ts 60.00% <0.00%> (-26.96%) ⬇️
...set-frontend/src/explore/actions/hydrateExplore.ts 42.10% <0.00%> (-19.44%) ⬇️
...lugin-chart-handlebars/src/plugin/controlPanel.tsx 50.00% <0.00%> (-16.67%) ⬇️
...c/dashboard/components/dnd/AddSliceDragPreview.jsx 50.00% <0.00%> (-10.00%) ⬇️
... and 117 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@riahk riahk merged commit 226712d into apache:master Aug 4, 2022
@mistercrunch mistercrunch added 🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels 🚢 2.1.0 and removed 🚢 2.1.3 labels Mar 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels size/M 🚢 2.1.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants