Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: explore warnings cleanup #20864

Merged

Conversation

diegomedina248
Copy link
Contributor

@diegomedina248 diegomedina248 commented Jul 26, 2022

SUMMARY

Changes:

  • Removes a duplicated translation application (table/handlebars plugins). The translations applied were exactly the same, so kept one.
  • PropTypes miss configuration
  • CSS properties from :nth-x to :nth-of-type (same end result, but cleans some warnings there)

BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF

--

TESTING INSTRUCTIONS

--

ADDITIONAL INFORMATION

  • Has associated issue:
  • Required feature flags:
  • Changes UI
  • Includes DB Migration (follow approval process in SIP-59)
    • Migration is atomic, supports rollback & is backwards-compatible
    • Confirm DB migration upgrade and downgrade tested
    • Runtime estimates and downtime expectations provided
  • Introduces new feature or API
  • Removes existing feature or API

@codecov
Copy link

codecov bot commented Jul 26, 2022

Codecov Report

Merging #20864 (6308af9) into master (9bf7ed5) will decrease coverage by 0.07%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master   #20864      +/-   ##
==========================================
- Coverage   66.33%   66.25%   -0.08%     
==========================================
  Files        1756     1756              
  Lines       66769    66928     +159     
  Branches     7059     7101      +42     
==========================================
+ Hits        44288    44342      +54     
- Misses      20684    20771      +87     
- Partials     1797     1815      +18     
Flag Coverage Δ
javascript 51.89% <ø> (-0.09%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...tend/plugins/plugin-chart-handlebars/src/consts.ts 66.66% <ø> (-8.34%) ⬇️
...lugin-chart-handlebars/src/plugin/controlPanel.tsx 50.00% <ø> (-16.67%) ⬇️
...nd/plugins/plugin-chart-table/src/controlPanel.tsx 45.58% <ø> (-0.79%) ⬇️
...end/src/components/PageHeaderWithActions/index.tsx 90.00% <ø> (ø)
...ntend/src/explore/components/ExploreChartPanel.jsx 69.01% <ø> (ø)
.../explore/components/ExploreViewContainer/index.jsx 52.19% <ø> (ø)
.../src/explore/components/controls/SelectControl.jsx 60.71% <ø> (ø)
superset-frontend/src/views/components/Menu.tsx 50.00% <ø> (ø)
superset-frontend/src/views/menu.tsx 0.00% <ø> (ø)
...components/DashboardBuilder/DashboardContainer.tsx 40.00% <0.00%> (-32.23%) ⬇️
... and 20 more

Help us with your feedback. Take ten seconds to tell us how you rate us.

Copy link
Member

@zhaoyongjie zhaoyongjie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the clear-up. LGTM

@zhaoyongjie zhaoyongjie merged commit 5d107b8 into apache:master Jul 26, 2022
@mistercrunch mistercrunch added 🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels 🚢 2.1.0 and removed 🚢 2.1.3 labels Mar 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels size/M 🚢 2.1.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants