Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(viz): Header scrolling for Time Table in dashboard #20874

Merged
merged 2 commits into from
Jul 27, 2022

Conversation

Antonio-RiveroMartnez
Copy link
Member

SUMMARY

Our dashboard includes dnd.less which makes our headers fall under the sparkline when scrolling. So we Increase the z-index in order to avoid such scenario.

BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF

BEFORE:
error

AFTER:
test

TESTING INSTRUCTIONS

  1. Create a time series table
  2. Add a time series column and make it a sparkline
  3. Add your chart to a dashboard
  4. On the dashboard, scroll the chart

Expected Results:

  1. The sparklines don't overlap with the header of the table

ADDITIONAL INFORMATION

  • Has associated issue:
  • Required feature flags:
  • Changes UI
  • Includes DB Migration (follow approval process in SIP-59)
    • Migration is atomic, supports rollback & is backwards-compatible
    • Confirm DB migration upgrade and downgrade tested
    • Runtime estimates and downtime expectations provided
  • Introduces new feature or API
  • Removes existing feature or API

- Increase the z-index so the sparkline doesn't overlap when scrolling in the dashboard
- Remove testing label
@codecov
Copy link

codecov bot commented Jul 26, 2022

Codecov Report

Merging #20874 (99817dc) into master (6e6d4e3) will decrease coverage by 0.01%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master   #20874      +/-   ##
==========================================
- Coverage   66.27%   66.25%   -0.02%     
==========================================
  Files        1757     1757              
  Lines       66955    66978      +23     
  Branches     7109     7117       +8     
==========================================
+ Hits        44374    44377       +3     
- Misses      20766    20784      +18     
- Partials     1815     1817       +2     
Flag Coverage Δ
javascript 51.91% <ø> (-0.03%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...rontend/src/visualizations/TimeTable/TimeTable.jsx 0.00% <ø> (ø)
...ntrols/MetricControl/AdhocMetricPopoverTrigger.tsx 78.04% <0.00%> (-5.74%) ⬇️
...ols/MetricControl/AdhocMetricEditPopover/index.jsx 75.53% <0.00%> (-2.50%) ⬇️
...ColumnSelectControl/ColumnSelectPopoverTrigger.tsx 63.63% <0.00%> (-1.89%) ⬇️
...ols/DndColumnSelectControl/ColumnSelectPopover.tsx 3.26% <0.00%> (-0.49%) ⬇️

Help us with your feedback. Take ten seconds to tell us how you rate us.

@@ -98,12 +98,13 @@ const defaultProps = {
url: '',
};

// @z-index-above-dashboard-charts + 1 = 11
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

FWIW, this is in the LESS codebase as z-index-above-dashboard-charts but obviously we're not using LESS here. This PR seems fine, but I wonder if we should make a levels/z-index registry in our Emotion theme. @michael-s-molina @eric-briscoe we might want to have a chat about how we can clean/support/scale these layers.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

or review, most of those should not be needed at all

@rusackas rusackas merged commit 99085d5 into apache:master Jul 27, 2022
@Antonio-RiveroMartnez Antonio-RiveroMartnez deleted the FIX-47655 branch August 2, 2022 21:15
@mistercrunch mistercrunch added 🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels 🚢 2.1.0 and removed 🚢 2.1.3 labels Mar 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels size/XS 🚢 2.1.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants