fix(dashboard): Incorrect scopes of cross filters

[kgabryje]

SUMMARY

Due to a bug introduced in #20743, cross filter scopes were not calculated correctly.

BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF

Before:

Screen.Recording.2022-07-29.at.4.47.52.PM.mov

After:

Screen.Recording.2022-07-31.at.12.20.53.mov

TESTING INSTRUCTIONS

1. Open a dashboard and apply cross filters
2. Verify that filters are applied correclty

ADDITIONAL INFORMATION

• Has associated issue:
• Required feature flags:
• Changes UI
• Includes DB Migration (follow approval process in SIP-59)
  • Migration is atomic, supports rollback & is backwards-compatible
  • Confirm DB migration upgrade and downgrade tested
  • Runtime estimates and downtime expectations provided
• Introduces new feature or API
• Removes existing feature or API

[codecov]

Codecov Report

Merging #20927 (af7bf28) into master (5ae0e83) will decrease coverage by 0.00%.
The diff coverage is 56.45%.

❗ Current head af7bf28 differs from pull request most recent head a6fc485. Consider uploading reports for the commit a6fc485 to get more accurate results

@@            Coverage Diff             @@
##           master   #20927      +/-   ##
==========================================
- Coverage   66.31%   66.30%   -0.01%     
==========================================
  Files        1758     1758              
  Lines       67039    67076      +37     
  Branches     7116     7122       +6     
==========================================
+ Hits        44457    44476      +19     
- Misses      20752    20770      +18     
  Partials     1830     1830              

Flag	Coverage Δ
javascript	52.00% <40.90%> (-0.02%)	⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files	Coverage Δ
...d/src/SqlLab/components/SaveDatasetModal/index.tsx	34.88% <0.00%> (-0.42%)	⬇️
superset-frontend/src/dashboard/actions/hydrate.js	1.92% <0.00%> (-0.04%)	⬇️
.../explore/components/ExploreViewContainer/index.jsx	52.19% <ø> (ø)
superset-frontend/src/utils/localStorageHelpers.ts	90.00% <ø> (ø)
...rset-frontend/src/explore/components/SaveModal.tsx	37.61% <43.24%> (+1.14%)	⬆️
superset/views/core.py	75.52% <66.66%> (-0.06%)	⬇️
...nd/src/explore/controlUtils/getSectionsToRender.ts	80.95% <100.00%> (+0.95%)	⬆️
superset/datasets/commands/update.py	94.04% <100.00%> (+0.07%)	⬆️
superset/datasets/dao.py	94.55% <100.00%> (+0.27%)	⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us.

[kgabryje]

/testenv up

[github-actions]

@kgabryje Ephemeral environment spinning up at http://35.166.237.28:8080. Credentials are admin/admin. Please allow several minutes for bootstrapping and startup.

[michael-s-molina]

/testenv up FEATURE_DASHBOARD_CROSS_FILTERS=true

[github-actions]

@michael-s-molina Ephemeral environment spinning up at http://35.91.49.127:8080. Credentials are admin/admin. Please allow several minutes for bootstrapping and startup.

[michael-s-molina]

LGTM

[github-actions]

Ephemeral environment shutdown and build artifacts deleted.