Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(import): error with disable_data_preview field #20932

Conversation

diegomedina248
Copy link
Contributor

SUMMARY

Updated V1 database extra schema to make import works with disable_data_preview field.

BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF

Before:

Screen.Recording.2022-08-01.at.09.00.57.mov

After:

new.mov

TESTING INSTRUCTIONS

  1. Create a DB connection (alternatively, you can modify an existing one).
  2. On the DB configuration pop up, navigate to the ADVANCED tab.
  3. Expand SQL Lab.
  4. Check Disable SQL Lab data preview queries.
  5. Save your changes.
  6. Hover the mouse over the modified DB, and click on the export icon under the Actions column.
  7. Try to import this ZIP file.

ADDITIONAL INFORMATION

  • Has associated issue:
  • Required feature flags:
  • Changes UI
  • Includes DB Migration (follow approval process in SIP-59)
    • Migration is atomic, supports rollback & is backwards-compatible
    • Confirm DB migration upgrade and downgrade tested
    • Runtime estimates and downtime expectations provided
  • Introduces new feature or API
  • Removes existing feature or API

@codecov
Copy link

codecov bot commented Aug 1, 2022

Codecov Report

Merging #20932 (a1eccac) into master (bc435e0) will decrease coverage by 11.45%.
The diff coverage is 100.00%.

@@             Coverage Diff             @@
##           master   #20932       +/-   ##
===========================================
- Coverage   66.30%   54.85%   -11.46%     
===========================================
  Files        1758     1758               
  Lines       67074    67075        +1     
  Branches     7122     7122               
===========================================
- Hits        44476    36796     -7680     
- Misses      20768    28449     +7681     
  Partials     1830     1830               
Flag Coverage Δ
hive 53.24% <100.00%> (+<0.01%) ⬆️
mysql ?
postgres ?
presto 53.14% <100.00%> (+<0.01%) ⬆️
python 57.89% <100.00%> (-23.67%) ⬇️
sqlite ?
unit 50.58% <100.00%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
superset/datasets/schemas.py 97.33% <ø> (ø)
superset/databases/schemas.py 76.84% <100.00%> (-21.75%) ⬇️
superset/utils/dashboard_import_export.py 0.00% <0.00%> (-100.00%) ⬇️
superset/key_value/commands/update.py 0.00% <0.00%> (-88.89%) ⬇️
superset/key_value/commands/delete.py 0.00% <0.00%> (-85.30%) ⬇️
superset/key_value/commands/delete_expired.py 0.00% <0.00%> (-80.77%) ⬇️
superset/dashboards/commands/importers/v0.py 15.62% <0.00%> (-76.25%) ⬇️
superset/datasets/commands/update.py 25.00% <0.00%> (-69.05%) ⬇️
superset/datasets/commands/create.py 29.41% <0.00%> (-68.63%) ⬇️
superset/datasets/commands/importers/v0.py 24.03% <0.00%> (-67.45%) ⬇️
... and 279 more

Help us with your feedback. Take ten seconds to tell us how you rate us.

@rusackas
Copy link
Member

rusackas commented Aug 2, 2022

Would it be reasonable enough to follow up with a test that runs through all of these fields to make sure support is maintained?

@rusackas
Copy link
Member

rusackas commented Aug 2, 2022

Thanks for catching the typos, too... maybe we need a spellcheck CI step ;)

@rusackas rusackas merged commit 6ce027d into apache:master Aug 2, 2022
@mistercrunch mistercrunch added 🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels 🚢 2.1.0 and removed 🚢 2.1.3 labels Mar 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels size/XS 🚢 2.1.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants