Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(charts): Hide Values greater than Max Y Axis Bound on Mixed Time Series with Bar series #21015

Merged
merged 3 commits into from
Aug 22, 2022

Conversation

Antonio-RiveroMartnez
Copy link
Member

SUMMARY

  • When Bar chart is used as serie type, we need to hide values that are greater than the max Y Axis Bound so users don't get inconsistency problems with other serie types. User can still see the value using the tooltip.

BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF

Before:
error

After:
test
tooltip_1
tooltip_2

TESTING INSTRUCTIONS

  1. Create a mixed time series chart
  2. Make sure value labels are on
  3. In your second query, set the Y-Axis Bound Maximum to lower than the initial value in the chart

ADDITIONAL INFORMATION

  • Has associated issue:
  • Required feature flags:
  • Changes UI
  • Includes DB Migration (follow approval process in SIP-59)
    • Migration is atomic, supports rollback & is backwards-compatible
    • Confirm DB migration upgrade and downgrade tested
    • Runtime estimates and downtime expectations provided
  • Introduces new feature or API
  • Removes existing feature or API

@codecov
Copy link

codecov bot commented Aug 8, 2022

Codecov Report

Merging #21015 (6e407d8) into master (5c2a1f8) will decrease coverage by 0.00%.
The diff coverage is 31.57%.

@@            Coverage Diff             @@
##           master   #21015      +/-   ##
==========================================
- Coverage   66.27%   66.27%   -0.01%     
==========================================
  Files        1770     1770              
  Lines       67530    67555      +25     
  Branches     7182     7191       +9     
==========================================
+ Hits        44758    44770      +12     
- Misses      20936    20945       +9     
- Partials     1836     1840       +4     
Flag Coverage Δ
javascript 52.00% <31.57%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...hart-echarts/src/MixedTimeseries/transformProps.ts 0.00% <0.00%> (ø)
...d/plugins/plugin-chart-echarts/src/utils/series.ts 84.29% <71.42%> (-0.80%) ⬇️
...uperset-ui-core/src/number-format/NumberFormats.ts 100.00% <100.00%> (ø)
...s/plugin-chart-echarts/src/Gauge/transformProps.ts 76.92% <0.00%> (-4.90%) ⬇️
...end/src/components/Datasource/DatasourceEditor.jsx 65.61% <0.00%> (-0.27%) ⬇️
...ns/plugin-chart-echarts/src/Gauge/controlPanel.tsx 66.66% <0.00%> (ø)

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

- When Bar chart is used as serie type, we need to hide values that are greater than the max Y Axis Bound.
- Simplify logic for getOverMaxHiddenFormatter
- Add tests for new getOverMaxHiddenFormatter util func
Copy link
Member

@rusackas rusackas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@rusackas rusackas merged commit bdcc0a9 into apache:master Aug 22, 2022
@mistercrunch mistercrunch added 🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels 🚢 2.1.0 and removed 🚢 2.1.3 labels Mar 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels size/L 🚢 2.1.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants