Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: migrate available_domains to api/v1 #21173

Merged

Conversation

zephyring
Copy link
Contributor

@zephyring zephyring commented Aug 24, 2022

SUMMARY

Migrate /available_domains/ to api/v1/available_domains/

BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF

TESTING INSTRUCTIONS

ADDITIONAL INFORMATION

  • Has associated issue:
  • Required feature flags:
  • Changes UI
  • Includes DB Migration (follow approval process in SIP-59)
    • Migration is atomic, supports rollback & is backwards-compatible
    • Confirm DB migration upgrade and downgrade tested
    • Runtime estimates and downtime expectations provided
  • Introduces new feature or API
  • Removes existing feature or API

@codecov
Copy link

codecov bot commented Aug 24, 2022

Codecov Report

Merging #21173 (b821bc1) into master (1d3a805) will decrease coverage by 0.00%.
The diff coverage is 96.66%.

@@            Coverage Diff             @@
##           master   #21173      +/-   ##
==========================================
- Coverage   66.45%   66.45%   -0.01%     
==========================================
  Files        1784     1786       +2     
  Lines       68142    68198      +56     
  Branches     7264     7264              
==========================================
+ Hits        45285    45320      +35     
- Misses      20989    21010      +21     
  Partials     1868     1868              
Flag Coverage Δ
hive 53.05% <90.00%> (+0.04%) ⬆️
mysql 80.84% <96.66%> (-0.04%) ⬇️
postgres 80.89% <96.66%> (-0.04%) ⬇️
presto 52.95% <90.00%> (+0.04%) ⬆️
python 81.37% <96.66%> (-0.04%) ⬇️
sqlite 79.41% <96.66%> (-0.03%) ⬇️
unit 50.67% <90.00%> (+0.09%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
superset/views/core.py 75.54% <0.00%> (-0.06%) ⬇️
superset/available_domains/api.py 100.00% <100.00%> (ø)
superset/available_domains/schemas.py 100.00% <100.00%> (ø)
superset/initialization/__init__.py 91.75% <100.00%> (+0.05%) ⬆️
superset/tasks/cache.py 61.15% <0.00%> (-12.76%) ⬇️
superset/databases/schemas.py 98.23% <0.00%> (-0.37%) ⬇️
superset/db_engine_specs/base.py 88.21% <0.00%> (-0.22%) ⬇️
superset/config.py 91.58% <0.00%> (-0.03%) ⬇️
superset/db_engine_specs/shillelagh.py 100.00% <0.00%> (ø)
superset/models/core.py 88.88% <0.00%> (+0.13%) ⬆️
... and 3 more

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

Copy link
Member

@geido geido left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM with Daniel's comment

@zephyring zephyring force-pushed the zef/migrate_available_domains_api_v1 branch from b161281 to e45dfb1 Compare August 29, 2022 17:48
superset/available_domains/api.py Outdated Show resolved Hide resolved
@dpgaspar dpgaspar merged commit c4b6fc5 into apache:master Sep 1, 2022
@dpgaspar dpgaspar deleted the zef/migrate_available_domains_api_v1 branch September 1, 2022 15:38
@mistercrunch mistercrunch added 🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels 🚢 2.1.0 and removed 🚢 2.1.3 labels Mar 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels size/L 🚢 2.1.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants