chore: E2E tests for the Drill to detail modal #21187
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
9 tasks
Codecov Report
@@ Coverage Diff @@
## master #21187 +/- ##
===========================================
- Coverage 66.40% 54.71% -11.70%
===========================================
Files 1783 1784 +1
Lines 68087 68132 +45
Branches 7261 7261
===========================================
- Hits 45215 37280 -7935
- Misses 21007 28987 +7980
Partials 1865 1865
Flags with carried forward coverage won't be shown. Click here to find out more.
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
|
Storybook has completed and can be viewed at |
…e/e2e-tests-drilltodetail-modal
|
Storybook has completed and can be viewed at |
| }); | ||
|
|
||
| it('opens the modal from the context menu', () => { | ||
| cy.get( |
There was a problem hiding this comment.
Can we extract the code that opens the modal to a function? Specifically this part:
cy.get(
"[data-test-viz-type='big_number_total'] [aria-label='More Options']",
).click();
cy.get('.ant-dropdown')
.not('.ant-dropdown-hidden')
.find("[role='menu'] [role='menuitem']")
.eq(5)
.should('contain', 'Drill to detail')
.click();
|
Storybook has completed and can be viewed at |
…e/e2e-tests-drilltodetail-modal
mistercrunch
added
🏷️ bot
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SUMMARY
This PR adds E2E tests for the drill to detail modal originally implemented in this PR #20728
Related RTL tests: #21148
It also adds a new ECharts Dashboard sample with some sample ECharts (as shown in the screenshot). The goal of this Dashboard is to grow and eventually show as many ECharts samples as possible. I'll continue enhancing this sample dashboard in separate PRs.
BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF
N.A.
TESTING INSTRUCTIONS
All the tests should succeed
ADDITIONAL INFORMATION