Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Keeps context menu in viewport #21212

Merged

Conversation

michael-s-molina
Copy link
Member

SUMMARY

This PR is an improvement to the right-click interactions on charts. It makes the context menu always display in the viewport to avoid the need for scrolling and to keep all options always visible.

BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF

Screen.Recording.2022-08-26.at.10.20.29.AM.mov

TESTING INSTRUCTIONS

Check the video for instructions.

ADDITIONAL INFORMATION

  • Has associated issue:
  • Required feature flags:
  • Changes UI
  • Includes DB Migration (follow approval process in SIP-59)
    • Migration is atomic, supports rollback & is backwards-compatible
    • Confirm DB migration upgrade and downgrade tested
    • Runtime estimates and downtime expectations provided
  • Introduces new feature or API
  • Removes existing feature or API

@github-actions
Copy link
Contributor

Storybook has completed and can be viewed at

@github-actions
Copy link
Contributor

Storybook has completed and can be viewed at

@codecov
Copy link

codecov bot commented Aug 26, 2022

Codecov Report

Merging #21212 (ea8984c) into master (68fa4d2) will decrease coverage by 0.00%.
The diff coverage is 22.22%.

@@            Coverage Diff             @@
##           master   #21212      +/-   ##
==========================================
- Coverage   66.36%   66.36%   -0.01%     
==========================================
  Files        1781     1781              
  Lines       67930    67938       +8     
  Branches     7255     7258       +3     
==========================================
+ Hits        45085    45087       +2     
- Misses      20982    20988       +6     
  Partials     1863     1863              
Flag Coverage Δ
javascript 52.26% <22.22%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...frontend/src/components/Chart/ChartContextMenu.tsx 44.00% <22.22%> (-8.95%) ⬇️

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

Copy link
Member

@zhaoyongjie zhaoyongjie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, Thanks for the improvement.

@michael-s-molina michael-s-molina merged commit 77f5458 into apache:master Aug 29, 2022
@mistercrunch mistercrunch added 🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels 🚢 2.1.0 and removed 🚢 2.1.3 labels Mar 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels size/S 🚢 2.1.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants