feat: Adds a helper text option to the Select component #21269
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #21269 +/- ##
==========================================
+ Coverage 66.43% 66.45% +0.01%
==========================================
Files 1784 1784
Lines 68185 68243 +58
Branches 7265 7265
==========================================
+ Hits 45298 45348 +50
- Misses 21018 21026 +8
Partials 1869 1869
Flags with carried forward coverage won't be shown. Click here to find out more.
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
geido
reviewed
Sep 1, 2022
| @@ -162,6 +170,16 @@ const StyledLoadingText = styled.div` | |||
| `} | |||
| `; | |||
|
|
|||
| const StyledHelperText = styled.div` | |||
There was a problem hiding this comment.
This looks identical to the AsyncSelect one. Should we put in a common file and import it from there?
There was a problem hiding this comment.
Yes. I left it duplicated on purpose in this PR because @cccs-RyanK is already working on the common file in #21094
Co-authored-by: Geido <60598000+geido@users.noreply.github.com>
Co-authored-by: Geido <60598000+geido@users.noreply.github.com>
mistercrunch
added
🏷️ bot
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SUMMARY
Adds a helper text option to the Select component to aid users when dealing with more complex flows.
@kasiazjc @codyml @cccs-RyanK
BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF
Screen.Recording.2022-08-31.at.10.53.55.AM.mov
TESTING INSTRUCTIONS
Check the video for instructions.
ADDITIONAL INFORMATION