Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Revert "#20095 - fix(database): make to display validation error msg when all … #21277

Merged

Conversation

sadpandajoe
Copy link
Member

SUMMARY

This reverts #20095. With this pull request when you submit an empty big query form it takes you to an error page

BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF

TESTING INSTRUCTIONS

  • Go through the different database connection forms
  • Submit an empty form
  • Submit a form with an error

Validate that error text is shown.

ADDITIONAL INFORMATION

  • Has associated issue:
  • Required feature flags:
  • Changes UI
  • Includes DB Migration (follow approval process in SIP-59)
    • Migration is atomic, supports rollback & is backwards-compatible
    • Confirm DB migration upgrade and downgrade tested
    • Runtime estimates and downtime expectations provided
  • Introduces new feature or API
  • Removes existing feature or API

@sadpandajoe sadpandajoe changed the title Revert "#20095 - fix(database): make to display validation error msg when all … fix: Revert "#20095 - fix(database): make to display validation error msg when all … Aug 31, 2022
@yousoph
Copy link
Member

yousoph commented Aug 31, 2022

/testenv up

@github-actions
Copy link
Contributor

@yousoph Ephemeral environment spinning up at http://35.89.82.118:8080. Credentials are admin/admin. Please allow several minutes for bootstrapping and startup.

@codecov
Copy link

codecov bot commented Aug 31, 2022

Codecov Report

Merging #21277 (4cecc4a) into master (a7fe485) will decrease coverage by 0.00%.
The diff coverage is 14.28%.

@@            Coverage Diff             @@
##           master   #21277      +/-   ##
==========================================
- Coverage   66.42%   66.42%   -0.01%     
==========================================
  Files        1784     1784              
  Lines       68236    68232       -4     
  Branches     7265     7263       -2     
==========================================
- Hits        45327    45323       -4     
  Misses      21040    21040              
  Partials     1869     1869              
Flag Coverage Δ
javascript 52.48% <14.28%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...onents/ErrorMessage/ErrorMessageWithStackTrace.tsx 60.00% <ø> (ø)
...c/views/CRUD/data/database/DatabaseModal/index.tsx 32.03% <0.00%> (-0.17%) ⬇️
...rontend/src/components/ErrorMessage/ErrorAlert.tsx 89.47% <100.00%> (-0.78%) ⬇️

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

Copy link
Member

@rusackas rusackas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approving to unblock. Maybe @zhaoyongjie can advise on how to fix forward.

@rusackas rusackas merged commit 4b22137 into apache:master Aug 31, 2022
@rusackas rusackas deleted the joe/fix-db-connection-error-with-blank-form branch August 31, 2022 22:57
@github-actions
Copy link
Contributor

Ephemeral environment shutdown and build artifacts deleted.

sadpandajoe added a commit to preset-io/superset that referenced this pull request Sep 1, 2022
… error msg when all … (apache#21277)

(cherry picked from commit 4b22137)
@sadpandajoe
Copy link
Member Author

🏷️ preset:2022.35

@mistercrunch mistercrunch added 🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels 🚢 2.1.0 labels Mar 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels preset:2022.35 size/M 🚢 2.1.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants