-
Notifications
You must be signed in to change notification settings - Fork 13.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: Revert "#20095 - fix(database): make to display validation error msg when all … #21277
fix: Revert "#20095 - fix(database): make to display validation error msg when all … #21277
Conversation
…cases (apache#20095)" This reverts commit d568999.
/testenv up |
@yousoph Ephemeral environment spinning up at http://35.89.82.118:8080. Credentials are |
Codecov Report
@@ Coverage Diff @@
## master #21277 +/- ##
==========================================
- Coverage 66.42% 66.42% -0.01%
==========================================
Files 1784 1784
Lines 68236 68232 -4
Branches 7265 7263 -2
==========================================
- Hits 45327 45323 -4
Misses 21040 21040
Partials 1869 1869
Flags with carried forward coverage won't be shown. Click here to find out more.
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Approving to unblock. Maybe @zhaoyongjie can advise on how to fix forward.
Ephemeral environment shutdown and build artifacts deleted. |
… error msg when all … (apache#21277) (cherry picked from commit 4b22137)
🏷️ preset:2022.35 |
SUMMARY
This reverts #20095. With this pull request when you submit an empty big query form it takes you to an error page
BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF
TESTING INSTRUCTIONS
Validate that error text is shown.
ADDITIONAL INFORMATION