fix: BigQuery cannot accept Time Grain #21489
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zhaoyongjie
commented
Sep 16, 2022
Comment on lines
-200
to
+203
| if (isPhysicalColumn(xAxisValue) && Array.isArray(xAxis?.options)) { | ||
| for (let i = 0; i < xAxis.options.length; i += 1) { | ||
| if (xAxis.options[i].column_name === xAxisValue) { | ||
| return !!xAxis.options[i].is_dttm; | ||
| } | ||
| } | ||
| if (isPhysicalColumn(xAxisValue)) { | ||
| return !!(xAxis?.options ?? []).find( | ||
| (col: ColumnMeta) => col?.column_name === xAxisValue, | ||
| )?.is_dttm; |
There was a problem hiding this comment.
bycatch: improve code smell
zhaoyongjie
commented
Sep 16, 2022
Codecov Report
@@ Coverage Diff @@
## master #21489 +/- ##
=======================================
Coverage 66.67% 66.68%
=======================================
Files 1791 1791
Lines 68478 68477 -1
Branches 7271 7271
=======================================
Hits 45661 45661
+ Misses 20956 20955 -1
Partials 1861 1861
Flags with carried forward coverage won't be shown. Click here to find out more.
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
villebro
reviewed
Sep 16, 2022
Let me check where the whole codebase calls this argument. |
villebro
approved these changes
Sep 16, 2022
|
I will refactor |
jinghua-qa
pushed a commit
to preset-io/superset
that referenced
this pull request
Sep 19, 2022
(cherry picked from commit 33509ab)
mistercrunch
added
🏷️ bot
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SUMMARY
This PR fixes Time Grain in the BigQuery as datasource and FF
GENERIC_CHART_AXESis enabled.BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF
After
Before
TESTING INSTRUCTIONS
ADDITIONAL INFORMATION