Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: can't show duckdb table names in the "SEE TABLE SCHEMA" dropdown list #21495

Merged
merged 1 commit into from
Sep 19, 2022

Conversation

forestlzj
Copy link
Contributor

@forestlzj forestlzj commented Sep 16, 2022

fix bug: #21210
the previous approach inspector.get_table_names() always gets table name in default "main" schema instead of getting table name from an input schema specified in superset UI

SUMMARY

fix bug #21210: can't show duckdb table names in the "SEE TABLE SCHEMA" dropdown list

TESTING INSTRUCTIONS

  1. create a duckdb file connection
  2. create a schema in the duckdb. e.g. "foo"
  3. create a table "tab1" in schema "foo"
  4. in sql lab, choose the duckdb connection, choose schema "foo" or any other
  5. it is expected table "tabi1" (or other) in the "SEE TABLE SCHEMA" dropdown list , before fixing , it is not showed anything

after installing duckdb_engine >=0.6.3 and the applying the fix in the PR, in step5, it can show the expected tables

ADDITIONAL INFORMATION

  • [Y] Has associated issue: fix duckdb - unable to list the table schema #21210
  • [ N] Required feature flags:
  • [ N] Changes UI
  • [ N] Includes DB Migration (follow approval process in SIP-59)
    • [ N] Migration is atomic, supports rollback & is backwards-compatible
    • [ N] Confirm DB migration upgrade and downgrade tested
    • [ N] Runtime estimates and downtime expectations provided
  • [ N] Introduces new feature or API
  • [N ] Removes existing feature or API

 fix bug: apache#21210
the previous approach inspector.get_table_names() always gets table name in default "main" schema instead of getting table name from an input schema specified in superset UI
@forestlzj forestlzj changed the title fix bug #21210 fix: can't show duckdb table names in the "SEE TABLE SCHEMA" dropdown list Sep 16, 2022
Copy link
Contributor

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Congrats on making your first PR and thank you for contributing to Superset! 🎉 ❤️
We hope to see you in our Slack community too!

@codecov
Copy link

codecov bot commented Sep 17, 2022

Codecov Report

Merging #21495 (dcf61cf) into master (b739e27) will not change coverage.
The diff coverage is 0.00%.

@@           Coverage Diff           @@
##           master   #21495   +/-   ##
=======================================
  Coverage   66.66%   66.66%           
=======================================
  Files        1793     1793           
  Lines       68492    68492           
  Branches     7277     7277           
=======================================
  Hits        45663    45663           
  Misses      20967    20967           
  Partials     1862     1862           
Flag Coverage Δ
hive 53.08% <0.00%> (ø)
mysql 78.20% <0.00%> (ø)
postgres 78.27% <0.00%> (ø)
presto 52.98% <0.00%> (ø)
python 81.41% <0.00%> (ø)
sqlite 76.76% <0.00%> (ø)
unit 51.05% <0.00%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
superset/db_engine_specs/duckdb.py 75.86% <0.00%> (ø)

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

Copy link
Member

@zhaoyongjie zhaoyongjie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested by DuckDB 5.0 and the latest engine, it works for me. Thanks for the fixing!

@zhaoyongjie zhaoyongjie merged commit fdb4702 into apache:master Sep 19, 2022
@mistercrunch mistercrunch added 🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels 🚢 2.1.0 and removed 🚢 2.1.3 labels Mar 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels size/XS 🚢 2.1.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

duckdb - unable to list the table schema
3 participants