-
Notifications
You must be signed in to change notification settings - Fork 13.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(rightmenu): Add Datasets to + Menu and Hide Databases when one has been connected #21530
Conversation
Codecov Report
@@ Coverage Diff @@
## master #21530 +/- ##
==========================================
+ Coverage 66.90% 66.92% +0.01%
==========================================
Files 1805 1805
Lines 69081 69106 +25
Branches 7378 7387 +9
==========================================
+ Hits 46218 46246 +28
+ Misses 20953 20952 -1
+ Partials 1910 1908 -2
Flags with carried forward coverage won't be shown. Click here to find out more.
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
1834868
to
35ed446
Compare
/testenv up |
@yousoph Ephemeral environment spinning up at http://35.86.84.95:8080. Credentials are |
35ed446
to
555fabd
Compare
@@ -0,0 +1,367 @@ | |||
/** |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
awesome a new test!!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great, and thanks for the speedy improvement on the dropdown menu, too!
/testenv up |
@yousoph Ephemeral environment spinning up at http://54.212.237.172:8080. Credentials are |
555fabd
to
5086bac
Compare
/testenv up |
@jinghua-qa Ephemeral environment spinning up at http://52.12.5.68:8080. Credentials are |
LGTM! |
5086bac
to
d78209a
Compare
Ephemeral environment shutdown and build artifacts deleted. |
ce7e38f
to
cc37470
Compare
/testenv up |
@yousoph Ephemeral environment spinning up at http://35.162.145.27:8080. Credentials are |
- check whether user has connected to only examples DB , if so, the plus menu will show Connect Database - If user has connected any other DB rather than just examples one, we show Connect dataset - Add tests to right menu
- Change our tests so we can add assertions using the displayed dropdown menus instead of just the setState calls - Putting back our useState hook
- Fix index used to render divider - Force blue and pointer hover for other menus that are not anchors so they all render the same - Stop querying the API to get DB info all the time when opening the menu, instead query the API only when opening Data menu
- Update our test file so we include tests for allow_file_upload
- Considering using the modal on pages with no SPA routes so CI doesn't fail
- Query non examples DB when user canDatabase OR canDataset
cc37470
to
78a047d
Compare
/testenv up |
Test the alpha and gamma role in local env and verified alpha user can see create dataset in + menu when 1 non-example db is added. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
@jinghua-qa Ephemeral environment spinning up at http://52.38.189.221:8080. Credentials are |
/testenv up FEATURE_SCHEDULED_QUERIES = TRUE |
@yousoph Ephemeral environment spinning up at http://52.40.39.59:8080. Credentials are |
Ephemeral environment shutdown and build artifacts deleted. |
SUMMARY
We are adding some extra logic to RightMenu so it checks for what databases the user has connected before displaying options in the dropdown.
BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF
Before:
After:
TESTING INSTRUCTIONS
ADDITIONAL INFORMATION