-
Notifications
You must be signed in to change notification settings - Fork 13.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: refactor AceEditorWrapper to functional component #21532
chore: refactor AceEditorWrapper to functional component #21532
Conversation
Codecov Report
@@ Coverage Diff @@
## master #21532 +/- ##
==========================================
+ Coverage 66.67% 66.71% +0.04%
==========================================
Files 1793 1795 +2
Lines 68523 68648 +125
Branches 7281 7316 +35
==========================================
+ Hits 45688 45799 +111
- Misses 20971 20989 +18
+ Partials 1864 1860 -4
Flags with carried forward coverage won't be shown. Click here to find out more.
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
@jinghua-qa @andrey-zayats Can you test it? |
|
SQL Lab editor |
Okay, I'll take a look |
/testenv up |
@andrey-zayats Ephemeral environment creation is currently limited to committers. |
/testenv up |
@jinghua-qa Ephemeral environment spinning up at http://34.221.133.37:8080. Credentials are |
User sees an empty page when trying to open a new tab in SQL lab. The same thing happens when the user follows the link of the saved query. Empty.page.mp4 |
@andrey-zayats If the issue is already in master then we need to create GitHub issue and fix in a separate PR. Right? |
Yeap, you're right |
@EugeneTorap PR LGTM, qa verified. |
superset-frontend/src/SqlLab/components/AceEditorWrapper/AceEditorWrapper.test.tsx
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! Thanks for your patient and hard work.
Ephemeral environment shutdown and build artifacts deleted. |
…che#21532)" This reverts commit 15c3c34.
SUMMARY
Converted AceEditorWrapper class component into functional component.
BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF
TESTING INSTRUCTIONS
ADDITIONAL INFORMATION