Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Drill to detail formatted val on TableChart #21719

Merged

Conversation

michael-s-molina
Copy link
Member

SUMMARY

Fixes the formatted value of a TableChart when interacting with the Drill to Detail context menu.

BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF

Screen Shot 2022-10-06 at 11 45 04 AM

Screen Shot 2022-10-06 at 11 41 46 AM

TESTING INSTRUCTIONS

Check that N/A values are displayed as such in the Drill to Detail context menu.

ADDITIONAL INFORMATION

  • Has associated issue:
  • Required feature flags:
  • Changes UI
  • Includes DB Migration (follow approval process in SIP-59)
    • Migration is atomic, supports rollback & is backwards-compatible
    • Confirm DB migration upgrade and downgrade tested
    • Runtime estimates and downtime expectations provided
  • Introduces new feature or API
  • Removes existing feature or API

@codecov
Copy link

codecov bot commented Oct 6, 2022

Codecov Report

Merging #21719 (fdde739) into master (f1fbaf8) will decrease coverage by 0.00%.
The diff coverage is 0.00%.

❗ Current head fdde739 differs from pull request most recent head f6a3ed2. Consider uploading reports for the commit f6a3ed2 to get more accurate results

@@            Coverage Diff             @@
##           master   #21719      +/-   ##
==========================================
- Coverage   66.82%   66.82%   -0.01%     
==========================================
  Files        1799     1799              
  Lines       68884    68885       +1     
  Branches     7319     7319              
==========================================
  Hits        46031    46031              
- Misses      20966    20967       +1     
  Partials     1887     1887              
Flag Coverage Δ
javascript 53.14% <0.00%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...tend/plugins/plugin-chart-table/src/TableChart.tsx 46.19% <0.00%> (-0.26%) ⬇️

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@michael-s-molina michael-s-molina merged commit eb2a134 into apache:master Oct 6, 2022
@mistercrunch mistercrunch added 🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels 🚢 2.1.0 and removed 🚢 2.1.3 labels Mar 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels size/XS 🚢 2.1.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants