Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Remove several React app console warnings and errors v2 #21725

Merged
merged 6 commits into from
Oct 28, 2022

Conversation

agl-developer
Copy link
Contributor

SUMMARY

Remove several warnings and errors all around the React app.

BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF

N/A

TESTING INSTRUCTIONS

Visit pages in:

/superset/welcome/
/dashboard/list/
/chart/list/
/databaseview/list/
/tablemodelview/list/
/savedqueryview/list/
/superset/sqllab/history/

ADDITIONAL INFORMATION

  • Has associated issue:
  • Required feature flags:
  • Changes UI
  • Includes DB Migration (follow approval process in SIP-59)
    • Migration is atomic, supports rollback & is backwards-compatible
    • Confirm DB migration upgrade and downgrade tested
    • Runtime estimates and downtime expectations provided
  • Introduces new feature or API
  • Removes existing feature or API

Remove required requirement on multiple optional fields
Fix errors in wrongly nested HTML elements
@codecov
Copy link

codecov bot commented Oct 14, 2022

Codecov Report

Merging #21725 (52acfed) into master (779d9f7) will increase coverage by 0.00%.
The diff coverage is 75.00%.

@@           Coverage Diff           @@
##           master   #21725   +/-   ##
=======================================
  Coverage   66.95%   66.95%           
=======================================
  Files        1807     1807           
  Lines       69196    69199    +3     
  Branches     7402     7402           
=======================================
+ Hits        46331    46334    +3     
  Misses      20954    20954           
  Partials     1911     1911           
Flag Coverage Δ
javascript 53.39% <75.00%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...frontend/src/components/ListView/Filters/index.tsx 52.17% <ø> (ø)
...set-frontend/src/components/ListViewCard/index.tsx 97.36% <0.00%> (ø)
...et-frontend/src/dashboard/components/Dashboard.jsx 64.77% <ø> (ø)
...rontend/src/dashboard/components/DashboardGrid.jsx 55.35% <ø> (ø)
...frontend/src/dashboard/components/Header/index.jsx 59.85% <ø> (ø)
...src/dashboard/components/PublishedStatus/index.jsx 100.00% <ø> (ø)
...end/src/dashboard/components/SliceHeader/index.tsx 88.67% <ø> (ø)
...end/src/dashboard/components/dnd/DragDroppable.jsx 76.92% <ø> (ø)
...uperset-frontend/src/dashboard/util/propShapes.jsx 92.30% <ø> (ø)
.../src/explore/components/controls/SelectControl.jsx 64.28% <ø> (ø)
... and 12 more

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@stephenLYZ
Copy link
Member

Thanks for the work, can we resolve the conflicting files?

# Conflicts:
#	superset-frontend/src/views/CRUD/chart/ChartList.tsx
@agl-developer
Copy link
Contributor Author

@stephenLYZ done!

Copy link
Member

@stephenLYZ stephenLYZ left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@stephenLYZ stephenLYZ merged commit 7f563cf into apache:master Oct 28, 2022
@mistercrunch mistercrunch added 🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels 🚢 2.1.0 and removed 🚢 2.1.3 labels Mar 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels size/L 🚢 2.1.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants